Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invoke callback for suspend notification, even if no dom content #1309

Merged
merged 8 commits into from
Jun 8, 2018
Merged

invoke callback for suspend notification, even if no dom content #1309

merged 8 commits into from
Jun 8, 2018

Conversation

sdetweil
Copy link
Collaborator

@sdetweil sdetweil commented Jun 7, 2018

Please send your pull requests the develop branch.
Don't forget to add the change to CHANGELOG.md.

  • Does the pull request solve a related issue?
  • If so, can you reference the issue?
    1308
  • What does the pull request accomplish? Use a list if needed.
    main/hideModule invoke module/hide callback even if no dom content
  • If it includes major visual changes please add screenshots.
    no visual changes

@MichMich
Copy link
Collaborator

MichMich commented Jun 7, 2018

Thanks for your PR. It seems something went wrong with the changelog file. All previous entries should remain.

@MichMich
Copy link
Collaborator

MichMich commented Jun 8, 2018

The PR seems to contain some listing errors. See the contribution policy for more info on how to solve this: https://github.com/MichMich/MagicMirror/blob/8010e6220d4cc68e9f9e3c1029998cc47df0f193/.github/CONTRIBUTING.md

@MichMich MichMich merged commit 8808031 into MagicMirrorOrg:develop Jun 8, 2018
@MichMich
Copy link
Collaborator

MichMich commented Jun 8, 2018

Great! Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants