Electron13

[khassel]

Managed to get the e2e tests running with electron v13 and spectron v15.

Tested new electron version on pi3 and ubuntu desktop.

Related to #2408.

[MichMich]

Great work!

I notice that almost all changes are the same electron options object in all different tests. Maybe it's worth it to extract that to a separate file so it can be reused?

[codecov-commenter]

Codecov Report

Merging #2609 (d617d4a) into develop (aad8141) will decrease coverage by 0.17%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #2609      +/-   ##
===========================================
- Coverage    70.64%   70.47%   -0.18%     
===========================================
  Files           16       16              
  Lines          821      823       +2     
===========================================
  Hits           580      580              
- Misses         241      243       +2     

Impacted Files	Coverage Δ
js/electron.js	72.22% <0.00%> (-2.78%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aad8141...d617d4a. Read the comment docs.

[khassel]

Maybe it's worth it to extract that to a separate file so it can be reused?

You mean something like

	defaultElectronOptions: {
		webPreferences: {
			nodeIntegration: true,
			enableRemoteModule: true,
			contextIsolation: false
		}

in a seperate file and then

	electronOptions: defaultElectronOptions

in every test config?

[MichMich]

Jean, or even better. A default test config that can be extended.

let config = testConfig({foo: bar})

The testConfig method will return the default config (including the electronOptions) and it will extend/overwrite with whatever you add as an argument.

Of course this can be a separate PR. But it might save some work in the future and makes PR's like these much cleaner.

[khassel]

o.k., will try this in a new PR.

[rejas]

LGTM!