Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed 'null' setting #366

Merged
merged 3 commits into from
Jul 1, 2016
Merged

Conversation

KirAsh4
Copy link
Contributor

@KirAsh4 KirAsh4 commented Jul 1, 2016

Removing this fixes the 'null' display on both latest versions of Edge and Internet Explorer browsers.

@MichMich
Copy link
Collaborator

MichMich commented Jul 1, 2016

That was some hardcore coding!

@KirAsh4
Copy link
Contributor Author

KirAsh4 commented Jul 1, 2016

It's stupid that those browsers convert it to a string.

@MichMich
Copy link
Collaborator

MichMich commented Jul 1, 2016

Those are stupid browsers ... ;)

@KirAsh4
Copy link
Contributor Author

KirAsh4 commented Jul 1, 2016

No argument there!

@MichMich
Copy link
Collaborator

MichMich commented Jul 1, 2016

I'm on my mobile, so could you send a pr for the change log?

@MichMich
Copy link
Collaborator

MichMich commented Jul 1, 2016

Could you add the issue number to the changelog (I'm just trying to keep you busy...)

@MichMich MichMich merged commit 1bb7226 into MagicMirrorOrg:develop Jul 1, 2016
@KirAsh4
Copy link
Contributor Author

KirAsh4 commented Jul 1, 2016

Took me a minute to find the Issue# ... heh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants