Add new max_cached_statement_lifetime parameter to Connection.
#109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elprans
reviewed
Apr 1, 2017
tests/test_prepare.py
Outdated
| @@ -456,3 +461,21 @@ class TestPrepare(tb.ConnectedTestCase): | |||
| # Check that we can run queries after a failed cursor | |||
| # operation. | |||
| await check_simple() | |||
|
|
|||
| async def test_prepare_24_max_use_count(self): | |||
There was a problem hiding this comment.
rename to test_prepare_max_lifetime
elprans
reviewed
Apr 1, 2017
asyncpg/connection.py
Outdated
| return self._max_lifetime | ||
|
|
||
| def set_max_lifetime(self, new_lifetime): | ||
| self._max_lifetime = new_lifetime |
There was a problem hiding this comment.
Should cancel and reschedule all cleanup callbacks here. Also, what happens if new_lifetime is zero?
There was a problem hiding this comment.
Also, what happens if new_lifetime is zero?
Updated the documentation for max_cached_statement_lifetime: 0 means that statements can be cached indefinitely.
elprans
reviewed
Apr 1, 2017
asyncpg/connection.py
Outdated
| Pass ``0`` to disable the cache. | ||
|
|
||
| :param int max_cached_statement_lifetime: | ||
| number of seconds a prepared statement can stay in the cache. |
There was a problem hiding this comment.
the maximum time in seconds a prepared statement will stay in the cache
|
@elprans pushed another commit addressing your review |
elprans
approved these changes
Apr 3, 2017
elprans
approved these changes
Apr 3, 2017
The parameter allows asyncpg to refresh cached prepared statements periodically. See also issue #76.
1st1
changed the title
max_cached_statement_use_count parameter to Connection.max_cached_statement_lifetime parameter to Connection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parameter allows asyncpg to refresh cached prepared statements
periodically.
See also issue #76.