Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete typing of connresource #1202

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DanielNoord
Copy link
Contributor

We can actually enable mypy --strict for this module now :)

Typing decorators correctly is notoriously hard and you need some pretty advanced concepts, but this does the trick. I have checked and both pyright and mypy consider this to be the correct type for all call sites to guarded.
The rest is pretty straightforward. The changes outside of the module are because mypy --strict doesn't allow calls to untyped functions, which I therefore had to fix.


def guarded(meth):
_ConnectionResourceT = TypeVar(
"_ConnectionResourceT", bound="ConnectionResource", contravariant=True
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bound needs to be stringified, even with from __future__ import annotations. I checked this locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant