Add support for COPY IN #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1st1
reviewed
May 10, 2017
| object mview | ||
| Py_buffer *pybuf | ||
|
|
||
| mview = PyMemoryView_GetContiguous(data, cpython.PyBUF_SIMPLE, b'C') |
There was a problem hiding this comment.
Don't you need to close mview after you use it?
1st1
reviewed
May 10, 2017
asyncpg/protocol/protocol.pyx
Outdated
| raise RuntimeError( | ||
| 'no encoder for OID {}'.format(codec.oid)) | ||
|
|
||
| while True: |
There was a problem hiding this comment.
Looks like this block can be simplified if we remove while True.
1st1
reviewed
May 10, 2017
asyncpg/protocol/protocol.pyx
Outdated
| break | ||
|
|
||
| elif reader is not None: | ||
| iterator = reader.__aiter__() |
There was a problem hiding this comment.
try:
aiter = reader.__aiter__
except AttributeError:
raise TypeError('reader is not an asynchronous iterator')
else:
iterator = aiter()
1st1
reviewed
May 10, 2017
asyncpg/protocol/protocol.pyx
Outdated
| except asyncio.TimeoutError: | ||
| self._write_copy_fail_msg('TimeoutError') | ||
| self._on_timeout(self.waiter) | ||
| await waiter |
There was a problem hiding this comment.
Maybe instead of await waiter do this:
try:
await waiter
except TimeoutError:
raise
else:
raise RuntimeError('TimoutError was not raised')
1st1
reviewed
May 10, 2017
asyncpg/protocol/protocol.pyx
Outdated
| 'invalid result waiter state on cancellation')) | ||
| else: | ||
| self.cancel_waiter.set_result(None) | ||
| self.cancel_waiter.set_result(None) |
There was a problem hiding this comment.
Did you intentionally remove that code? If so the comment above it needs to be adjusted.
1st1
reviewed
May 10, 2017
| raise RuntimeError('failure in source') | ||
|
|
||
| with self.assertRaisesRegexp(RuntimeError, 'failure in source'): | ||
| await self.con.copy_to_table('copytab', source=_Source()) |
There was a problem hiding this comment.
Can we add self.assertEqual(await self.con.fetchval('select 1'), 1) to all tests that test failures to make sure that the protocol is fully recovered?
1st1
approved these changes
May 11, 2017
elprans
force-pushed
the
copy_in
branch
3 times, most recently
from
b310291 to
445775c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds two new Connection methods: copy_to_table() and
copy_records_to_table() that allow copying data to the specified
table either in text or, in the latter case, record form.
Related-To #123.
Closes #21.