Document pgbouncer-related prepared statement breakage #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1st1
reviewed
Oct 23, 2017
.github/ISSUE_TEMPLATE.md
Outdated
| @@ -12,6 +12,8 @@ Thank you! | |||
|
|
|||
| * **asyncpg version**: | |||
| * **PostgreSQL version**: | |||
| * **If you are using a PostgreSQL SaaS, then which, and can you reproduce | |||
| the issue with a local PostgreSQL install?**: | |||
There was a problem hiding this comment.
Maybe reword this to: "Are you using a PostgreSQL SaaS? If so, which? Can you reproduce the issue with a local postgres install?".
elprans
force-pushed
the
document-pgbouncer
branch
from
7546abe to
38d45f2
Compare
1st1
approved these changes
Oct 23, 2017
1st1
reviewed
Oct 23, 2017
| END; $$ LANGUAGE plpgsql; | ||
| """) | ||
| except asyncpg.DuplicatePreparedStatementError as e: | ||
| self.assertTrue('pgbouncer' in e.hint) |
kxepal
reviewed
Oct 23, 2017
tests/test_prepare.py
Outdated
| await self.con.execute(""" | ||
| DO $$ BEGIN | ||
| RAISE EXCEPTION | ||
| 'duplicate statement' USING ERRCODE = '26000'; |
There was a problem hiding this comment.
I think better change "duplicate statement" to "invalid statement" to not think that this is a copy-paste issue. Or message plays some important role?
|
Nice hint! |
elprans
force-pushed
the
document-pgbouncer
branch
3 times, most recently
from
03adc34 to
c6893e9
Compare
elprans
force-pushed
the
document-pgbouncer
branch
from
c6893e9 to
746ba37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues: #121 and #149.