Add rudimentary server capability detection. #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1st1
reviewed
Mar 16, 2017
asyncpg/connection.py
Outdated
| else: | ||
| self._intro_query = introspection.INTRO_LOOKUP_TYPES | ||
|
|
||
| _reset_query = '' |
There was a problem hiding this comment.
Can you factor this code into a separate method _get_reset_query()? I'd also only call it from Connection.reset() (only pooled connections are likely to ever call reset()).
asyncpg/capabilities.py
Outdated
| @@ -0,0 +1,37 @@ | |||
|
|
|||
| # Copyright (C) 2016-present the ayncpg authors and contributors | |||
1st1
reviewed
Mar 16, 2017
asyncpg/capabilities.py
Outdated
| ServerCapabilities.__doc__ = 'PostgreSQL server capabilities.' | ||
|
|
||
|
|
||
| def detect_server_capabilities(server_version, connection_settings): |
elprans
force-pushed
the
server-capabilities
branch
from
a317d2e to
b9ad3c3
Compare
1st1
reviewed
Mar 16, 2017
asyncpg/connection.py
Outdated
| def _detect_server_capabilities(server_version, connection_settings): | ||
| if hasattr(connection_settings, 'crdb_version'): | ||
| # CocroachDB detected. | ||
| advisory_locks = cursors = notifications = plpgsql = sql_reset = False |
There was a problem hiding this comment.
Can you make it a multiline assignment. Will minimize the diff when we need to add a new one.
1st1
approved these changes
Mar 16, 2017
elprans
force-pushed
the
server-capabilities
branch
from
b9ad3c3 to
05375ed
Compare
Add basic server capability detection mechanism based on server version and parameters reported by the server through ParameterStatus messages. This allows altering certain asyncpg behaviour based on the connected server. Specifically, this allows asyncpg to connect to CochroachDB servers. Fixes #87.
elprans
force-pushed
the
server-capabilities
branch
from
05375ed to
32d72c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add basic server capability detection mechanism based on server version
and parameters reported by the server through ParameterStatus messages.
This allows altering certain asyncpg behaviour based on the connected
server.
Specifically, this allows asyncpg to connect to CockroachDB servers.
Fixes #87.