Fixing issues regarding psycopg2 vs psycopg3 benchmark #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semabtariq1
commented
Feb 14, 2024
semabtariq1
commented
- Updating dependencies versions
- A hack to overcome out of index error while running psycopg3 batch inserts benchmark
- Adding conn.commit() so that we can commit data into PostgreSQL
- Adding python-psycopg2 and python-psycopg3 keywords so that they can be run from pgbench utility as well
- A hack to overcome out of index error while running psycopg3 batch inserts benchmark - Adding conn.commit() so that we can commit data into PostgreSQL - Adding python-psycopg2 and python-psycopg3 keywords so that they can be run from pgbench utility as well
elprans
reviewed
Feb 14, 2024
| @@ -247,7 +250,8 @@ def sync_worker(executor, eargs, start, duration, timeout): | |||
| max_latency = req_time | |||
| if req_time < min_latency: | |||
| min_latency = req_time | |||
| latency_stats[req_time] += 1 | |||
| if req_time <= 200000: | |||
There was a problem hiding this comment.
Silently truncating latencies like that does not seem right. Why is this change necessary?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.