Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

__init__.pyi added on #570 breaks mypy #575

Closed
vkottler opened this issue Oct 15, 2023 · 6 comments
Closed

__init__.pyi added on #570 breaks mypy #575

vkottler opened this issue Oct 15, 2023 · 6 comments

Comments

@vkottler
Copy link

vkottler commented Oct 15, 2023

  • uvloop version: 0.18.0
  • Python version: 3.11.4
  • Platform: Linux (Ubuntu)
  • Can you reproduce the bug with PYTHONASYNCIODEBUG in env?: N/A
  • Does uvloop behave differently from vanilla asyncio? How?: N/A
vkottler at vkottler-tower in ~/src/vkottler/vcorelib (dev/3.0.1)
$ ./venv/bin/mypy tests vcorelib setup.py tasks
vcorelib/asyncio/__init__.py:205: error: Module has no attribute "new_event_loop"  [attr-defined]
vcorelib/asyncio/__init__.py:209: error: Module has no attribute "install"  [attr-defined]
Found 2 errors in 1 file (checked 154 source files)

This appears to be caused by the addition of this file: https://github.com/MagicStack/uvloop/blob/master/uvloop/__init__.pyi.

It does not contain any information about e.g. __all__ defined in init.py.

edit: also reproduces in GitHub Actions

vkottler added a commit to vkottler/vcorelib that referenced this issue Oct 15, 2023
Issue: MagicStack/uvloop#575. Can
revert when underlying issue fixed.
vkottler added a commit to vkottler/vcorelib that referenced this issue Oct 15, 2023
Issue: MagicStack/uvloop#575. Can
revert when underlying issue fixed.
vkottler added a commit to vkottler/vcorelib that referenced this issue Oct 15, 2023
Issue: MagicStack/uvloop#575. Can
revert when underlying issue fixed.
vkottler added a commit to vkottler/vcorelib that referenced this issue Oct 15, 2023
Issue: MagicStack/uvloop#575. Can
revert when underlying issue fixed.
vkottler added a commit to vkottler/vcorelib that referenced this issue Oct 15, 2023
Issue: MagicStack/uvloop#575. Can
revert when underlying issue fixed.
@vkottler
Copy link
Author

For my situation, I can just revert this commit: vkottler/vcorelib@81a1ba3 if/when there's a fix.

@fantix
Copy link
Member

fantix commented Oct 15, 2023

I believe #573 shall fix this issue.

@Kludex
Copy link

Kludex commented Oct 18, 2023

Is a release expected to happen soon?

@graingert
Copy link
Contributor

@fantix can you cut a release with this fix in? it's blocking CI on uvicorn.

If you're busy that's ok just let me know and I'll depend on the git HEAD in uvicorn

@fantix
Copy link
Member

fantix commented Oct 19, 2023

Yeah sure - I'll try to include some more stuff and cut a release this weekend.

@danking
Copy link

danking commented Oct 23, 2023

Thanks @fantix ! I think we can now close this issue.

https://github.com/MagicStack/uvloop/releases/tag/v0.19.0

@fantix fantix closed this as completed Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants