Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #169: asyncio.base_futures.InvalidStateError: invalid state #170

Closed
wants to merge 4 commits into from

Conversation

andr-04
Copy link
Contributor

@andr-04 andr-04 commented Jun 17, 2018

No description provided.

@andr-04
Copy link
Contributor Author

andr-04 commented Jun 18, 2018

Actually, this is not correct behavior yet, I'm testing the additional patch now. Stay tuned please.

@andr-04
Copy link
Contributor Author

andr-04 commented Jun 18, 2018

ee13f17 not helped yet. @1st1, if you have an idea why -- let me know.

The difference between base loop and uvloop implementation is base tried to call internal _sock_recv without a reader first. In uvloop it's Cython method, so an initial reading is absent and goes through reader. It looks a collision between removing and adding reader occurs.

How can we do this?

1st1 added a commit that referenced this pull request Jun 22, 2018
@1st1
Copy link
Member

1st1 commented Jun 22, 2018

I made a new PR that is essentially a refactoring of your fix and another unittest: #173

@1st1
Copy link
Member

1st1 commented Jun 22, 2018

Closing in favour of #173

@1st1 1st1 closed this Jun 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants