Skip to content

Add python 3.7 on CI #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Add python 3.7 on CI #179

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dccc314
enable python 3.7 on linux
waghanza Jul 4, 2018
cd465bb
add python3.7 on osx
waghanza Jul 4, 2018
dc6f501
specify python compatibility
waghanza Jul 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ language: generic
env:
global:
- PYMODULE=uvloop
- RELEASE_PYTHON_VERSIONS="3.5 3.6"
- RELEASE_PYTHON_VERSIONS="3.5 3.6 3.7"

- S3_UPLOAD_USERNAME=oss-ci-bot
- S3_UPLOAD_BUCKET=magicstack-oss-releases
Expand Down Expand Up @@ -42,6 +42,13 @@ matrix:
env: BUILD=tests,wheels PYTHON_VERSION=3.6.5
branches: {only: [releases]}

- os: osx
osx_image: xcode7.3
# Travis macOS env does not support Python yet,
# so we have to set things up manually in install.sh.
env: BUILD=tests,wheels PYTHON_VERSION=3.7.0
branches: {only: [releases]}

- os: linux
dist: trusty
sudo: false
Expand All @@ -65,6 +72,15 @@ matrix:
services: [docker]
env: BUILD=tests,wheels,release

- os: linux
Copy link
Member

@elprans elprans Jul 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we only need one "release" job for Linux. The actual wheel build is done inside manylinux docker images which are selected with the RELEASE_PYTHON_VERSIONS environment variable.

Copy link
Author

@waghanza waghanza Jul 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting https://travis-ci.org/MagicStack/uvloop/builds/400060588 to finish

may I suggest using 1 CI that support OSX / Linux / Windows (instead of 2)
I've found https://cirrus-ci.org/

Copy link
Member

@1st1 1st1 Jul 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that Cirrus CI is just a couple of days old. We'll wait until it's mature before spending any time trying to integrate it.

dist: xenial
branches: {only: [releases]}
Copy link
Member

@1st1 1st1 Jul 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop branches

sudo: required
language: python
python: "3.7"
services: [docker]
Copy link
Member

@1st1 1st1 Jul 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop services

env: BUILD=tests,wheels,release
Copy link
Member

@1st1 1st1 Jul 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop "wheels,release" from BUILD.

Copy link
Author

@waghanza waghanza Jul 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also be the same for other python versions, no ?

Copy link
Member

@1st1 1st1 Jul 4, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the same for other versions. There's only one target with BUILD=tests,wheels,release (3.5) which builds the wheels and releases them. All other targets (except macos) only run tests. So 3.7 linux target should also just run tests.


cache:
pip

Expand Down