Skip to content

Switch to Github Action, and fix for Python 3.9 #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 7, 2020
Merged

Switch to Github Action, and fix for Python 3.9 #372

merged 5 commits into from
Dec 7, 2020

Conversation

fantix
Copy link
Member

@fantix fantix commented Dec 7, 2020

I haven't touched the releasing part, but I've mimicked the part in test.yml based on how it is done in asyncpg.

Fixes #318
Fixes #354
Fixes #355
Fixes #361
Closes #368
Closes #371

@fantix fantix marked this pull request as ready for review December 7, 2020 03:32
@fantix fantix requested a review from elprans December 7, 2020 03:32
@elprans elprans requested a review from 1st1 December 7, 2020 03:42
1st1
1st1 approved these changes Dec 7, 2020
View reviewed changes
Copy link
Member

@1st1 1st1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, great work, Fantix. Huge thanks!

I'll leave it to @elprans to review the GitHub Actions part of this PR; the uvloop/tests fixes look good to me though.

elprans
elprans approved these changes Dec 7, 2020
View reviewed changes
Copy link
Member

@elprans elprans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI part LGTM. Leaving the 3.9 compatibility bits for @1st1 to review. Thanks!

@1st1 1st1 merged commit 311997e into master Dec 7, 2020
@1st1 1st1 deleted the ci branch December 7, 2020 03:43
@fantix
Copy link
Member Author

fantix commented Dec 7, 2020

Thank you both for the lightning review! ⚡

@elprans elprans mentioned this pull request Dec 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1 1st1 approved these changes

@elprans elprans elprans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@fantix @1st1 @elprans @shadchin