Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix call_soon_threadsafe thread safety #421

Merged
merged 2 commits into from
Jul 13, 2021

Conversation

fantix
Copy link
Member

@fantix fantix commented Jul 12, 2021

Don't start the idle handler in other threads or signal handlers, leaving the job to _on_wake().

Co-authored-by: hexin02 hexin02@megvii.com
Closes: #407 #408

Don't start the idle handler in other threads or signal handlers,
leaving the job to `_on_wake()`.

Co-authored-by: hexin02 <hexin02@megvii.com>
@fantix fantix requested a review from 1st1 July 12, 2021 18:11
@fantix fantix marked this pull request as ready for review July 12, 2021 18:26
Copy link
Member

@1st1 1st1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, great to see this fixed. Thanks to all involved!

@fantix fantix merged commit 4b803b1 into MagicStack:master Jul 13, 2021
@fantix fantix deleted the t408-thread-safety branch July 13, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants