Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version bump of cibuildwheel #447

Closed
wants to merge 2 commits into from
Closed

Conversation

WAKayser
Copy link

Update cibuildwheel to 2.2.0, which will enable musllinux wheel builds. This is useful for environments like alpine linux containers.

Update cibuildwheel to 2.2.0, which will enable musllinux wheel builds. This is useful for environments like alpine linux containers.
@br3ndonland
Copy link

Thanks for taking care of this @WAKayser. I landed here after wondering why my uvloop installs were still so slow on Alpine Linux.

Cross-referencing the related PR #435 reviewed by @fantix. Would appreciate a review here as well.

Happy to help, if there's any way I can help move this forward.

@ben9923
Copy link
Contributor

ben9923 commented Jun 27, 2022

I believe further changes are needed here.

There's currently a workaround for cffi wheels, invoking yum.

# This is needed for now because cffi has no cp310 wheels
CIBW_BEFORE_ALL_LINUX: "yum -y install libffi-devel"

Running this command on Alpine would obviously fail, so it must be changed.
One option could simply be checking if yum exists as part of the command.
Another option would be using cibuildwheel's override mechanism (toml-only, added quite recently IIRC,):

[[tool.cibuildwheel.overrides]]
select = "*-manylinux*"
before-all = "yum -y install libffi-devel"

While this is actually unnecessary now, as cffi has cp310 wheels, adding cp311 will re-introduce this requirement.
cffi also has no musllinux wheels, but it seems like the default image already has libffi-dev.

Might also be worth upgrading cibuildwheel to the latest version. It will change from manylinux2010 to manylinux2014 so if it's not desired an image would need to be set explicitly.

I would love to see musl wheels too, let me know if I can help :)
CC @elprans @fantix

@fantix
Copy link
Member

fantix commented Sep 11, 2022

Thanks for the PR! This is already done now and musl wheels are built successfully in my latest test, will be included in the next release.

@fantix fantix closed this Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants