Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #4 is caused by the segment size inside
/proc/iomem
for the memory range starting at0x1000
being different from the segment from/proc/kcore
's header by0x800
bytes for some reason. This is not an issue with the code as reading/proc/iomem
and dumping the header of/proc/kcore
usingreadelf
confirms this discrepancy. This pull request fixes this issue by warning instead of panicking if the segment sizes differ and uses the max between the two to dump, ensuring that no data is lost because of the mismatch.DumpItForLinux Output
readelf -a /proc/kcore
cat /proc/iomem