Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Hyperlink to the currents IconPack Website #228

Merged
merged 4 commits into from
Oct 5, 2020

Conversation

timunie
Copy link
Contributor

@timunie timunie commented Oct 3, 2020

What has changed?

You can now link the IconPack to its original website. This should make the IconPacks more known to new users and is IMO a benefit for the IconPack-Maintainer.

What is the current state?

I have implement it for the first three IconPacks. If I get an 👍 I'll update the others as well.

Preview

image

Closed issues

Closes #227

- Use the same Command for all views 
- Use the new Metadata-Attribute
- Works now even in the "All"-Tab
@timunie timunie force-pushed the HyperlinksToOriginalIconPacks branch from 3634adc to 9655c5e Compare October 4, 2020 20:42
@timunie timunie changed the title [WIP][RFC] Implement Hyperlink to the currents IconPack Website Implement Hyperlink to the currents IconPack Website Oct 4, 2020
@timunie
Copy link
Contributor Author

timunie commented Oct 4, 2020

Update

With #231 we have now a very generic solution. This solution is now implemented into the Browser:

  • Use the new MetaDataAttribute to get the URLs
  • Added a Button to show the License as well as the Projects Website

Screenshot

image

Co-authored-by: Jan Ivar Z. Carlsen <jizc@outlook.com>
@punker76 punker76 added this to the 4.6.0 milestone Oct 5, 2020
@punker76 punker76 merged commit c63574d into MahApps:develop Oct 5, 2020
@punker76
Copy link
Member

punker76 commented Oct 5, 2020

@timunie your changes have been merged, thanks for your contribution 👍

@timunie timunie deleted the HyperlinksToOriginalIconPacks branch October 5, 2020 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Add Hyperlinks to the IconPack's website
3 participants