-
-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve IconPacks Browser with new features #232
Conversation
d328904
to
f2d62cf
Compare
@timunie appveyor shows this error
|
It did work and compile, but now the @punker76 please give me a short 👍 or 👎 . 🙏 |
Here some thoughts (suggestions):
|
Hi @punker76 Thank you for the suggestions. The issue was caused by the last rebase, I'll fix this when I have some time for it. Moving the searchtextbox to the right was also something I was thinking about.
🤔 Let's see if there is a way or not. Do you have an example which icon is inverted? I would like to use this for testing Info: I would like to use the Nevertheless I can make smaller PR for useful features. Especially the Happy coding |
iirc the fontawesome icons are inverted |
019fa7f
to
f14ce61
Compare
@punker76 do you mean the following image by
If yes, I think I know how to export the data in the right direction. We "just" have to translate the |
Here are some exported examples: |
c77bbf0
to
a8ba5af
Compare
- Iconpacks will always be in alphabetical order - More Space for Icons - More Space for an export panel
- The DataTemplate is now selected in code behind. This is more generic and needs less adjustments for new IconPacks
Do more work. Do more Work Implement Search- Shortcut Ctrl+F
Smoothing Expander Animation
…e own NullToUnsetValueConverter The wrong template binding raises some errors which results in bad performance.
def72eb
to
a039fce
Compare
I think this is more readable
- Added Header with detailed information - Imporve Export - Use Template for Bitmap as well - Improve ColorPicker usage
Hi @punker76, should we offer support for custom Happy coding and a nice weekend |
2594492
to
93f4fd6
Compare
Hi @punker76 , I think I am good to go. Functions which are now implemented are:
I which everyone happy coding, happy x-mas 🎄 and a happy new year 🎆 |
@timunie your changes have been merged, thanks for your contribution 👍 |
What changed?
This is a proposal for a different IconPacksBrowser. For now not all Features are implemented as it is more meant as a proposal at this moment. Currently this changed:
HamburgerMenu
instead ofTabControl
PreviewPane
to display, adjust and (later) export the selected IconIconPacks
addedScreenshots
Closed Issues
Closes #230
Closes #57
Closes #12
Closes #51