Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve IconPacks Browser with new features #232

Merged
merged 40 commits into from
Sep 10, 2021

Conversation

timunie
Copy link
Contributor

@timunie timunie commented Oct 4, 2020

What changed?

This is a proposal for a different IconPacksBrowser. For now not all Features are implemented as it is more meant as a proposal at this moment. Currently this changed:

  • Use HamburgerMenu instead of TabControl
  • Use a PreviewPane to display, adjust and (later) export the selected Icon
  • More space for Icons if needed
  • DataTemplate is now more "generic". This should lead to less effort if there are more IconPacks added

Screenshots

HamburgerMenuProposal

Closed Issues

Closes #230
Closes #57
Closes #12
Closes #51

@punker76
Copy link
Member

punker76 commented Oct 8, 2020

@timunie appveyor shows this error

C:\projects\mahapps-metro-iconpacks\src\MahApps.Metro.IconPacks.Browser\MainWindow.xaml(338,11): error MC3000: 'The 'Canvas' start tag on line 315 position 18 does not match the end tag of 'DataTemplate'. Line 338, position 11.' XML is not valid.

@timunie
Copy link
Contributor Author

timunie commented Oct 8, 2020

It did work and compile, but now the XAML of the MainWindow is totally rubbish. I have no idea what happend here. But if you are interested in this, I'll double-check. If you want to stick with the current design we can also close this PR.

@punker76 please give me a short 👍 or 👎 . 🙏

@punker76
Copy link
Member

punker76 commented Oct 8, 2020

Here some thoughts (suggestions):

  • "Filter by" should be always visible, maybe on the right top on the title header of the showing icon page
  • Save as Svg could be difficult, because some paths are inverted (and not the original one)

@timunie
Copy link
Contributor Author

timunie commented Oct 9, 2020

Hi @punker76

Thank you for the suggestions. The issue was caused by the last rebase, I'll fix this when I have some time for it. Moving the searchtextbox to the right was also something I was thinking about.

Save as Svg could be difficult, because some paths are inverted (and not the original one)

🤔 Let's see if there is a way or not. Do you have an example which icon is inverted? I would like to use this for testing

Info: I would like to use the ColorPicker MahApps/MahApps.Metro#3930 to let the user select the colors. So I would also like to wait for this before you merge this PR.

Nevertheless I can make smaller PR for useful features. Especially the DataTemplateSelector seems to be very handy. Should I make a separate PR for this?

Happy coding
Tim

@Insire
Copy link

Insire commented Oct 9, 2020

Do you have an example which icon is inverted?

iirc the fontawesome icons are inverted

@timunie
Copy link
Contributor Author

timunie commented Nov 7, 2020

@punker76 do you mean the following image by

Save as Svg could be difficult, because some paths are inverted (and not the original one)

image

If yes, I think I know how to export the data in the right direction. We "just" have to translate the LayoutTransform-Matrix to svg.

@timunie
Copy link
Contributor Author

timunie commented Nov 9, 2020

@punker76 do you mean the following image by

Save as Svg could be difficult, because some paths are inverted (and not the original one)

image

If yes, I think I know how to export the data in the right direction. We "just" have to translate the LayoutTransform-Matrix to svg.

Here are some exported examples:
Example-Export.zip

…e own NullToUnsetValueConverter

The wrong template binding raises some errors which results in bad performance.
I think this is more readable
- Added Header with detailed information
- Imporve Export
- Use Template for Bitmap as well
- Improve ColorPicker usage
@timunie
Copy link
Contributor Author

timunie commented Dec 4, 2020

Hi @punker76,

should we offer support for custom ExportTemplates and CopyToClipboardTemplates? That way the user could modify the template and for example copy the icon with Width, Height or Foreground set.

Happy coding and a nice weekend
Tim

@timunie timunie changed the title [WIP][RFC] HamburgerMenu proposal [RFC] HamburgerMenu proposal Dec 12, 2020
@timunie
Copy link
Contributor Author

timunie commented Dec 12, 2020

Hi @punker76 ,

I think I am good to go. Functions which are now implemented are:

  • other design
  • search via [Ctrl]+[F]
  • configure preview size and color
  • Export icon to svg, xaml and image
  • Display more icon information
  • Support for theming
  • Support for custom Export and CopyToClipboard-Templates.

image

I which everyone happy coding, happy x-mas 🎄 and a happy new year 🎆
Tim

@punker76 punker76 changed the title [RFC] HamburgerMenu proposal Improve IconPacks Browser with new features Sep 10, 2021
@punker76
Copy link
Member

finally

image

@punker76 punker76 merged commit b4afcf9 into MahApps:develop Sep 10, 2021
@punker76
Copy link
Member

@timunie your changes have been merged, thanks for your contribution 👍

@timunie timunie deleted the HamburgerMenuProposal branch September 12, 2021 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants