Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaked xmlns prefix to match previous automatic prefix #278

Merged
merged 1 commit into from
Oct 2, 2021

Conversation

jizc
Copy link
Contributor

@jizc jizc commented Oct 2, 2021

What changed?

I changed the XmlnsPrefix from iconpacks to iconPacks.

Why?

Before XmlnsPrefix was added to the AssemblyInfo, VS automatically used iconPacks as the prefix. As we have been using this icon pack for years, this means our code base has hundreds of uses of the previous prefix.

Any new uses now automatically adds the new prefix, meaning we will have different prefixes in different files for the same package. This causes issues when copying XAML between files that are using different prefixes.

Another annoying thing is that out-of-the-box ReSharper views the new prefix as a typo. Meaning we'll need to either keep renaming the prefix to the old prefix in every new file, or add iconpacks to the custom dictionary. The latter is of course the easiest, but feels unnecessary.

For these reasons, in my opinion, the best solution is to revert back to the previous prefix.

@dnfadmin
Copy link

dnfadmin commented Oct 2, 2021

CLA assistant check
All CLA requirements met.

@punker76 punker76 added the Bug label Oct 2, 2021
@punker76 punker76 added this to the 4.10.0 milestone Oct 2, 2021
@punker76
Copy link
Member

punker76 commented Oct 2, 2021

@jizc Thank you for this. Yes, I think it was a mistake.

@punker76 punker76 merged commit 6ee407e into MahApps:develop Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants