Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hiding close button and title leaves blank space in top-positioned flyouts #2485

Closed
DavidIQ opened this issue Apr 26, 2016 · 0 comments · Fixed by #2523
Closed

Hiding close button and title leaves blank space in top-positioned flyouts #2485

DavidIQ opened this issue Apr 26, 2016 · 0 comments · Fixed by #2523
Assignees
@punker76
Milestone
1.3.0

Comments

@DavidIQ
Copy link

DavidIQ commented Apr 26, 2016

What steps will reproduce this issue?

When setting TitleVisibility and CloseButtonVisibility so that they don't show the space where the two controls are supposed to show on the left of a top-positioned fly-out is still displayed on the flyout. This is because dpHeader is still present and has a margin applied to it even though nothing is displaying inside of it:
image

Expected outcome

No blank space shown to the left of the control.

Environment

  • MahApps.Metro 1.2.4
  • Windows 10
  • Visual Studio 2015
  • .NET Framework 4.5.2
@punker76 punker76 self-assigned this Apr 27, 2016
@punker76 punker76 added this to the 1.3.0 milestone Apr 27, 2016
@punker76 punker76 mentioned this issue May 23, 2016
Merged
punker76 added a commit that referenced this issue May 25, 2016
@punker76
sample for #2485
442e5d9
punker76 added a commit that referenced this issue May 30, 2016
@punker76
fix #2485
c420f2e
punker76 added a commit that referenced this issue Jun 1, 2016
@punker76
Merge pull request #2523 from MahApps/2485-Flyout-improvement
d60bd41 
flyout improvement caused by #2485
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@punker76 punker76

Labels
None yet
Milestone
1.3.0
Development

Successfully merging a pull request may close this issue.

flyout improvement caused by #2485 MahApps/MahApps.Metro
2 participants
@DavidIQ @punker76