Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutomationId based on name fix #2381

Merged
merged 1 commit into from
Feb 29, 2016
Merged

AutomationId based on name fix #2381

merged 1 commit into from
Feb 29, 2016

Conversation

petvetbr
Copy link
Contributor

Set AutomationId based on x:Name property

Now the AutomationId property is set according to the control x:Name property.

For NumericUpDown:

  • Textbox: "PART_TextBox{x:Name value}"
  • DownButton : "PART_NumericDown{x:Name value}"
  • UpButton: "PART_NumericUp{x:Name value}"

For Flyout:

-NavButton: "nav{x:Name value}"
#2166

@punker76
Copy link
Member

@thoemmi What do you think? /cc @xxMUROxx

@thoemmi
Copy link
Collaborator

thoemmi commented Feb 29, 2016

I don't know anything about the automation API, but it looks fine for me 😊

punker76 added a commit that referenced this pull request Feb 29, 2016
AutomationId based on name fix
@punker76 punker76 merged commit b53934b into MahApps:develop Feb 29, 2016
@michaelmairegger
Copy link
Contributor

Can someone explain in short what Automation is useful for?

@petvetbr
Copy link
Contributor Author

petvetbr commented Mar 1, 2016

@xxMUROxx there are 2 areas where automation is used a lot:

Automated UI tests
Accessibility

In both it is important to manipulate the UI using alternatives to de usual keyboard/mouse/touch methods, so that is when automation comes into play.

@michaelmairegger
Copy link
Contributor

@petvetbr Ah, ok. Then I think the same behavior is missing for other custom controls that are implemented in this library too. e.g. ToggleSwith, DropDownButton, SplitButton, etc...

@petvetbr
Copy link
Contributor Author

petvetbr commented Mar 1, 2016

@xxMUROxx

Ok, I´ll take a look at the other controls and see if I can make them more "automation friendly",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants