Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ThemeManager changes not working with different (STA) threads #3873

Merged
merged 2 commits into from
Jul 7, 2020

Conversation

punker76
Copy link
Member

@punker76 punker76 commented Jul 7, 2020

Describe the changes you have made to improve this project

Execute ThemeManager changes at the current Dispatcher UI thread.

Closed Issues

Closes #3872

@punker76 punker76 added this to the 2.1.2 milestone Jul 7, 2020
@punker76 punker76 merged commit eeb66c3 into develop Jul 7, 2020
@punker76 punker76 deleted the fix/GH-3872-ThemeManager_Threads branch July 7, 2020 10:25
@punker76 punker76 modified the milestones: 2.1.2, 2.2.0 Jul 13, 2020
@amkuchta
Copy link
Contributor

@punker76 is there any way that we can get this into the next release instead of 2.2.0? Not sure if you are using Semantic Versioning or not, but this seems like a bugfix to me, not a breaking feature that requires a minor version update.

Also, I really want it 😂

@timunie
Copy link
Collaborator

timunie commented Jul 20, 2020

@amkuchta the PR is already merged so I think it will be in the next release. Maybe there will be no 2.1.2 because of another change which adds a new feature.

Happy coding
Tim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Theme Manager wont work with 2 Main windows on different (STA) Threads
3 participants