Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop shadow effect memory leak #3975

Merged
merged 2 commits into from
Nov 22, 2020
Merged

Drop shadow effect memory leak #3975

merged 2 commits into from
Nov 22, 2020

Conversation

lipchev
Copy link
Contributor

@lipchev lipchev commented Nov 22, 2020

Describe the changes you have made to improve this project

  • Modified the top row of the CleanWindowDemo demonstrating possible memory leaks with the DropShadowEffect
  • Setting x:Shared="False" on all DropShadowEffect (fixing the memory leak)

Unit test

  • there is a dotMemory unit testing nuget out there but don't know much about it..

Additional context

I've updated all DropShadowEffects (including VS & DropShadowBrush)- assuming there is no usage where x:Shared=True is appropriate

Closed Issues

Closes #3974

@punker76 punker76 added this to the 2.4.0 milestone Nov 22, 2020
@punker76 punker76 merged commit 3f8387d into MahApps:develop Nov 22, 2020
@punker76
Copy link
Member

@lipchev your changes have been merged, thanks for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Fix
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

Memory leak with the DropShadowEffect
2 participants
@lipchev @punker76