Removed old, almost unused and undocumented lib/Unserialize

MahoCommerce · Sep 24, 2024 · ceded0d · ceded0d
1 parent 0a6d48a
commit ceded0d
Show file tree

Hide file tree

Showing 11 changed files with 4 additions and 621 deletions.
diff --git a/app/code/core/Mage/Core/Helper/String.php b/app/code/core/Mage/Core/Helper/String.php
@@ -512,23 +512,14 @@ public function uniOrd($c)
      * UnSerialize string
      * @param string $str
      * @return mixed|null
-     * @throws Exception
      */
     public function unserialize($str)
     {
         if (is_null($str)) {
             return null;
         }
-        $reader = new Unserialize_Reader_ArrValue('data');
-        $prevChar = null;
-        for ($i = 0; $i < strlen($str); $i++) {
-            $char = $str[$i];
-            $result = $reader->read($char, $prevChar);
-            if (!is_null($result)) {
-                return $result;
-            }
-            $prevChar = $char;
-        }
+
+        return unserialize($str);
     }
 
     /**
@@ -553,9 +544,7 @@ public function isSerializedArrayOrObject($data)
     public function validateSerializedObject($str)
     {
         if ($this->isSerializedArrayOrObject($str)) {
-            try {
-                $this->unserialize($str);
-            } catch (Exception $e) {
+            if (!unserialize($str)) {
                 return false;
             }
         }

diff --git a/app/code/core/Mage/Sales/Model/Quote/Item.php b/app/code/core/Mage/Sales/Model/Quote/Item.php
@@ -516,7 +516,7 @@ public function compare($item)
                 // dispose of some options params, that can cramp comparing of arrays
                 if (is_string($itemOptionValue) && is_string($optionValue)) {
                     try {
-                        /** @var Unserialize_Parser $parser */
+                        /** @var Mage_Core_Helper_UnserializeArray $parser */
                         $parser = Mage::helper('core/unserializeArray');
 
                         $_itemOptionValue =

diff --git a/lib/Unserialize/Parser.php b/lib/Unserialize/Parser.php
diff --git a/lib/Unserialize/Reader/Arr.php b/lib/Unserialize/Reader/Arr.php
diff --git a/lib/Unserialize/Reader/ArrKey.php b/lib/Unserialize/Reader/ArrKey.php
diff --git a/lib/Unserialize/Reader/ArrValue.php b/lib/Unserialize/Reader/ArrValue.php