[flutter_local_notifications] Fix crash on latest Flutter master due to ambiguous method call #2355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmackall
changed the title
|
Thanks for the PR. Was about to create a branch to ask others to test so much appreciated for this. Would you be able to update your branch with latest changes from master though? I noticed PRs created weren't running th the formatting jobs. I merged some changes that should fix this now but would like to confirm it's firing not just for me but others too |
|
Can confirm the fix works on latest flutter master. |
Daniel-BD
added a commit
to abilia/flutter_local_notifications
that referenced
this pull request
Aug 14, 2024
Clone of main repo fix: MaikuB#2355
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2329, by casting the null argument to be a
Bitmapso that we choosehttps://developer.android.com/reference/android/app/Notification.BigPictureStyle#bigLargeIcon(android.graphics.Bitmap)
of the two methods.
Verified by running the example app.