Skip to content

Comments

Staging#1054

Merged
MrgSub merged 20 commits intomainfrom
staging
May 23, 2025
Merged

Staging#1054
MrgSub merged 20 commits intomainfrom
staging

Conversation

@MrgSub
Copy link
Collaborator

@MrgSub MrgSub commented May 23, 2025

Summary by CodeRabbit

  • New Features

    • Folder and label counts are now displayed as badges throughout the mail navigation, providing clearer visibility of unread or relevant items.
  • Bug Fixes

    • Unread indicator badges are now shown for threads in the "Bin" folder when appropriate.
  • Chores

    • Removed unused environment variable and related Google OAuth configuration for cleaner setup.

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
zero-staging 5ce9ac5 May 23 2025, 07:53 PM

@coderabbitai
Copy link
Contributor

coderabbitai bot commented May 23, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The changes introduce a consistent "count" property for mail folders and labels across both frontend and backend. Components are updated to accept and display this count, and backend logic is adjusted to standardize unread thread counting. Configuration for Google OAuth consent is simplified by removing related environment variables and conditional logic.

Changes

File(s) Change Summary
apps/mail/components/magicui/file-tree.tsx, apps/mail/components/ui/recursive-folder.tsx Extended Folder and RecursiveFolder components to accept and display a numeric "count" property.
apps/mail/components/ui/nav-main.tsx Integrated useStats to provide counts for labels/folders, added getLabelCount, and passed counts to navigation components.
apps/mail/components/mail/mail-list.tsx Modified unread badge logic to show for all folders except "Sent", removing special handling for "Bin".
apps/server/src/lib/auth-providers.ts, apps/server/wrangler.jsonc Removed Google OAuth prompt config and related FORCE_GMAIL_CONSENT environment variable.
apps/server/src/lib/driver/google.ts Standardized label count logic to always use unread threads count.
apps/server/src/types.ts Added optional count property to Label type.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant NavMain
    participant useStats
    participant RecursiveFolder
    participant Folder

    User->>NavMain: Render navigation
    NavMain->>useStats: Fetch stats
    NavMain->>RecursiveFolder: Render with count from stats
    RecursiveFolder->>Folder: Pass count prop
    Folder->>User: Display folder with badge if count > 0
Loading

Suggested reviewers

  • ahmetskilinc

Poem

In folders deep, the counts now show,
Unread mail badges all aglow.
Stats and labels, numbers bright,
Guide our paws through mail each night.
With cleaner code and simpler flow,
This bunny cheers, "Let inboxes grow!"
🐇📬✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9baf71f and 5ce9ac5.

📒 Files selected for processing (8)
  • apps/mail/components/magicui/file-tree.tsx (4 hunks)
  • apps/mail/components/mail/mail-list.tsx (1 hunks)
  • apps/mail/components/ui/nav-main.tsx (6 hunks)
  • apps/mail/components/ui/recursive-folder.tsx (2 hunks)
  • apps/server/src/lib/auth-providers.ts (0 hunks)
  • apps/server/src/lib/driver/google.ts (1 hunks)
  • apps/server/src/types.ts (1 hunks)
  • apps/server/wrangler.jsonc (0 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@MrgSub MrgSub merged commit 592d699 into main May 23, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants