FIX(MAIL): transform YouTube iframe to clickable link in emails

[vagxrth]

Description

This pull request addresses an issue where YouTube links pasted into the email composer, which were displayed as embedded video previews, were not being included in the sent email, either as an embed or a clickable link.

The fix involves the following:

• When an email is sent or a draft is saved, any YouTube iframe embeds within the email body are now transformed into standard HTML anchor (<a>) tags. These links point directly to the YouTube video.
• This transformation logic has been encapsulated in a reusable utility function, transformYouTubeIframesToLinks, located in email-utils.ts.
• The regex used for identifying YouTube iframes has been significantly improved to handle various edge cases, such as single or double-quoted src attributes, whitespace variations, and self-closing iframe tags.
• Input validation has been added for the extracted YouTube video ID to ensure it adheres to a safe format.
• The video ID is now processed with encodeURIComponent, and the final URL is HTML-escaped before being embedded in the anchor tag to enhance security and prevent potential XSS vulnerabilities or malformed links.

---

Type of Change

Please delete options that are not relevant.

• 🐛 Bug fix (non-breaking change which fixes an issue)
• ✨ New feature (non-breaking change which adds functionality - the utility function)
• 🎨 UI/UX improvement (resolves discrepancy between composer preview and sent email)
• 🔒 Security enhancement (input validation and URL encoding/escaping for YouTube links)

Areas Affected

Please check all that apply:

• Email Integration (content processing before sending/saving drafts)
• User Interface/Experience (ensures intended links are sent)

Testing Done

Describe the tests you've done:

• Manual testing performed (verified that YouTube links are now correctly sent as clickable links)

Security Considerations

For changes involving data or authentication:

• No sensitive data is exposed
• Input validation is implemented (for YouTube video IDs)

Checklist

• I have read the CONTRIBUTING document
• My code follows the project's style guidelines
• I have performed a self-review of my code
• I have commented my code, particularly in complex areas
• My changes generate no new warnings
• All tests pass locally (assuming existing tests pass with these changes)
• Any dependent changes are merged and published

Screenshots/Recordings

before.mov

after.mov

---

By submitting this pull request, I confirm that my contribution is made under the terms of the project's license.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[BlankParticle]

this was a bug, youtube videos were never meant to be rendered in the message compose box
Youtube along with a few other renderers have been removed and now pasting links would just render a normal link instead of an Iframe, sorry for the comnfusion
ref #1082

[vagxrth]

Yeah cool, understood thanks a lot!

this was a bug, youtube videos were never meant to be rendered in the message compose box Youtube along with a few other renderers have been removed and now pasting links would just render a normal link instead of an Iframe, sorry for the comnfusion ref #1082