fixes issues with selected email optimistic updates#1146
Merged
BlankParticle merged 1 commit intostagingfrom May 29, 2025
Merged
fixes issues with selected email optimistic updates#1146BlankParticle merged 1 commit intostagingfrom
BlankParticle merged 1 commit intostagingfrom
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
BlankParticle
approved these changes
May 29, 2025
Contributor
Merge activity
|
MrgSub
pushed a commit
that referenced
this pull request
May 29, 2025
Improved mail list hotkey functionality by adding a `shouldUseHover` flag to determine when to use hover actions versus bulk selection actions. - Added a `shouldUseHover` flag that checks if bulk selection is empty - Updated hotkey handlers (markAsRead, markAsUnread, archiveEmail) to use this flag when determining whether to act on hovered email or selected emails - Removed unused imports and functions: - Removed `useQueryClient`, `useTRPC`, `useStats` imports - Removed `refetch`, `mutateStats`, `invalidateCount` functions - Removed a console.log statement in the selectAll function - Updated dependency arrays in useCallback hooks to include the new `shouldUseHover` flag 1. Test mail list hotkeys with no emails selected: - Hover over an email and use keyboard shortcuts to mark as read/unread or archive - Verify actions apply only to the hovered email 2. Test mail list hotkeys with emails selected: - Select multiple emails and use keyboard shortcuts - Verify actions apply to all selected emails regardless of hover state This change improves the user experience by making the hotkey behavior more predictable and intuitive. When users have explicitly selected emails, actions should apply to those selections. When no emails are selected, actions should apply to the currently hovered email. This creates a more consistent interaction model and prevents accidental operations on unintended emails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Improved mail list hotkey functionality by adding a
shouldUseHoverflag to determine when to use hover actions versus bulk selection actions.What changed?
shouldUseHoverflag that checks if bulk selection is emptyuseQueryClient,useTRPC,useStatsimportsrefetch,mutateStats,invalidateCountfunctionsshouldUseHoverflagHow to test?
Test mail list hotkeys with no emails selected:
Test mail list hotkeys with emails selected:
Why make this change?
This change improves the user experience by making the hotkey behavior more predictable and intuitive. When users have explicitly selected emails, actions should apply to those selections. When no emails are selected, actions should apply to the currently hovered email. This creates a more consistent interaction model and prevents accidental operations on unintended emails.