feat (i18n): new translation keys across all supported languages#1178
feat (i18n): new translation keys across all supported languages#1178abhiifour wants to merge 2 commits intoMail-0:stagingfrom
Conversation
|
""" WalkthroughThis update adds new localized action labels for bulk operations and filter clearing to the mail application's shortcut/action sections across multiple language JSON files. No existing keys are modified or removed; only new translation entries are appended to each locale file. Changes
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (21)
apps/mail/locales/ar.json(1 hunks)apps/mail/locales/ca.json(1 hunks)apps/mail/locales/cs.json(1 hunks)apps/mail/locales/de.json(1 hunks)apps/mail/locales/en.json(1 hunks)apps/mail/locales/es.json(1 hunks)apps/mail/locales/fa.json(1 hunks)apps/mail/locales/fr.json(1 hunks)apps/mail/locales/hi.json(1 hunks)apps/mail/locales/hu.json(1 hunks)apps/mail/locales/ja.json(1 hunks)apps/mail/locales/ko.json(1 hunks)apps/mail/locales/lv.json(1 hunks)apps/mail/locales/nl.json(1 hunks)apps/mail/locales/pl.json(1 hunks)apps/mail/locales/pt.json(1 hunks)apps/mail/locales/ru.json(1 hunks)apps/mail/locales/tr.json(1 hunks)apps/mail/locales/vi.json(1 hunks)apps/mail/locales/zh_CN.json(1 hunks)apps/mail/locales/zh_TW.json(1 hunks)
🔇 Additional comments (30)
apps/mail/locales/hi.json (2)
469-469: Verify unexpected addition ofselectUnderCursor.
The PR summary and objectives mention five new keys, but this locale file also introduces aselectUnderCursorentry. Please confirm whether this key was intended to be part of this feature.Likely an incorrect or invalid review comment.
470-474: Approve translations for bulk action keys.
The entries forclearAllFilters,markAsImportant,bulkArchive,bulkDelete, andbulkStarare correctly added and the Hindi translations align with the UI context.apps/mail/locales/pt.json (2)
469-469: Verify unexpected addition ofselectUnderCursor.
This file also addsselectUnderCursor, which isn’t described in the PR objectives. Ensure this key is intended.Likely an incorrect or invalid review comment.
470-474: Approve translations for bulk action keys.
The Portuguese translations forclearAllFilters,markAsImportant,bulkArchive,bulkDelete, andbulkStarare accurate and well-placed.apps/mail/locales/ko.json (2)
469-469: Verify unexpected addition ofselectUnderCursor.
The keyselectUnderCursorappears here but isn’t mentioned in the PR summary. Please confirm its inclusion.Likely an incorrect or invalid review comment.
470-474: Approve translations for bulk action keys.
Korean translations forclearAllFilters,markAsImportant,bulkArchive,bulkDelete, andbulkStarare correct and consistent.apps/mail/locales/ja.json (2)
469-469: Verify unexpected addition ofselectUnderCursor.
This file addsselectUnderCursoralong with the five intended keys. The PR objectives don’t reference it—please verify.Likely an incorrect or invalid review comment.
470-474: Approve translations for bulk action keys.
Japanese translations forclearAllFilters,markAsImportant,bulkArchive,bulkDelete, andbulkStarare properly added.apps/mail/locales/zh_TW.json (2)
462-462: Verify unexpected addition ofselectUnderCursor.
TheselectUnderCursorkey was introduced but not mentioned in the PR summary—please confirm its intention.Likely an incorrect or invalid review comment.
463-467: Approve translations for bulk action keys.
Traditional Chinese translations forclearAllFilters,markAsImportant,bulkArchive,bulkDelete, andbulkStarare correct and consistent.apps/mail/locales/nl.json (2)
470-474: Approve Dutch translations for new shortcut actions
The entries forclearAllFilters,markAsImportant,bulkArchive,bulkDelete, andbulkStarare correctly translated and follow the existing key conventions.
469-469: ClarifyselectUnderCursoraddition
The keyselectUnderCursorappears alongside the five new action labels but wasn't mentioned in the PR objectives. Please confirm if it belongs in this feature or should be part of a separate change.Likely an incorrect or invalid review comment.
apps/mail/locales/ar.json (2)
469-474: Approve Arabic translations for new shortcut actions
The Arabic translations forclearAllFilters("مسح جميع الفلاتر"),markAsImportant("وضع علامة كمهم"),bulkArchive("أرشفة جماعية"),bulkDelete("حذف جماعي"), andbulkStar("تمييز جماعي بنجمة") are accurate and align with the existing localization style.
469-469: ClarifyselectUnderCursoraddition
The keyselectUnderCursorhas been added but is not mentioned in the PR objectives. Please verify if its inclusion is intentional.Likely an incorrect or invalid review comment.
apps/mail/locales/vi.json (2)
463-467: Approve Vietnamese translations for new shortcut actions
The Vietnamese translations forclearAllFilters,markAsImportant,bulkArchive,bulkDelete, andbulkStarare correct and consistent with the locale’s phrasing.
462-462: ClarifyselectUnderCursoraddition
The keyselectUnderCursoris introduced here but wasn’t listed in the PR summary. Confirm if it should be included in this release.Likely an incorrect or invalid review comment.
apps/mail/locales/es.json (2)
470-474: Approve Spanish translations for new shortcut actions
The Spanish translations forclearAllFilters,markAsImportant,bulkArchive,bulkDelete, andbulkStarare accurate and maintain consistency with existing keys.
469-469: ClarifyselectUnderCursoraddition
TheselectUnderCursorkey appears alongside the new bulk action labels but is not documented in the PR scope. Please verify its intended inclusion.Likely an incorrect or invalid review comment.
apps/mail/locales/pl.json (2)
470-474: Approve Polish translations for new shortcut actions
The Polish translations forclearAllFilters,markAsImportant,bulkArchive,bulkDelete, andbulkStar(Wyczyść wszystkie filtry,Oznacz jako ważne,Zarchiwizuj zbiorczo,Usuń zbiorczo,Oznacz gwiazdką zbiorczo) are correct and align with the locale standards.
469-469: ClarifyselectUnderCursoraddition
The keyselectUnderCursorwas added but not referenced in the PR objectives. Confirm whether it should be part of this feature.Likely an incorrect or invalid review comment.
apps/mail/locales/ca.json (1)
469-474: Approve Catalan translations additions
The new shortcut keys (clearAllFilters,markAsImportant,bulkArchive,bulkDelete,bulkStar) are correctly named and placed within theshortcuts.actionssection. The Catalan translations follow the imperative style used elsewhere, and there are no trailing-comma or structural issues.apps/mail/locales/tr.json (1)
469-474: Approve Turkish translations additions
The five new keys are inserted in the proper location undershortcuts.actions, and the Turkish translations are consistent with the imperative tone of existing entries. JSON syntax and formatting are correct.apps/mail/locales/fr.json (1)
469-474: Approve French translations additions
Translations forclearAllFilters,markAsImportant,bulkArchive,bulkDelete, andbulkStarare correctly localized and adhere to the existing formatting and structure. No issues detected.apps/mail/locales/cs.json (1)
469-474: Approve Czech translations additions
The new keys and their Czech translations are properly added undershortcuts.actions, matching the style and punctuation of neighboring entries. JSON remains valid.apps/mail/locales/ru.json (1)
469-474: Approve Russian translations additions
New shortcut entries are correctly appended in the right JSON section, and the Russian translations are idiomatic and consistent with existing labels. Syntax is valid.apps/mail/locales/fa.json (1)
462-467: Approve new translation keys.
The five new shortcut action labels (clearAllFilters,markAsImportant,bulkArchive,bulkDelete,bulkStar) have been correctly added undercommon.shortcuts.actionswith accurate Farsi translations.apps/mail/locales/zh_CN.json (1)
462-467: Approve new translation keys.
The new shortcuts (clearAllFilters,markAsImportant,bulkArchive,bulkDelete,bulkStar) have been appended undercommon.shortcuts.actionswith correct Simplified Chinese translations.apps/mail/locales/hu.json (1)
462-467: Approve new translation keys.
Added the five new bulk-action and filter-clearing labels undercommon.shortcuts.actionswith proper Hungarian translations.apps/mail/locales/lv.json (1)
469-474: Approve new translation keys.
The keysclearAllFilters,markAsImportant,bulkArchive,bulkDelete, andbulkStarare properly inserted undercommon.shortcuts.actionswith correct Latvian translations.apps/mail/locales/de.json (1)
469-469: Confirm unintended addition ofselectUnderCursor.
TheselectUnderCursorkey is annotated as a new entry but isn’t mentioned in the PR description or AI-generated summary. Please confirm whether this addition was intended in this PR.Likely an incorrect or invalid review comment.
|
You only need to add them to |
2 participants
Description
Added 5 new keys and provided translations for all supported locales:
Type of Change
Please delete options that are not relevant.
Areas Affected
Please check all that apply:
Testing Done
Describe the tests you've done:
Security Considerations
For changes involving data or authentication:
Checklist
Screenshots/Recordings
By submitting this pull request, I confirm that my contribution is made under the terms of the project's license.
Summary by CodeRabbit