add zsh installation in postCreateCommand#1244
Conversation
WalkthroughThe Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
.devcontainer/devcontainer.json (3)
34-34: Move Zsh installation to Dockerfile build for caching and faster startup
Installing viapostCreateCommandruns on every container start. Consider moving:RUN apt-get update && apt-get install -y zshinto your
Dockerfileto leverage Docker layer caching and speed up subsequent container launches.
34-34: Use the official Devcontainer Zsh feature
Instead of manually runningapt, leverage the built-in Zsh feature for idempotent, cross-distro installation (with optional Oh My Zsh support):"features": { "ghcr.io/devcontainers/features/zsh:1": {} }Would you like me to draft the updated
devcontainer.jsonusing this feature?
34-34: Use non-interactiveapt-getfor script robustness
In headless/container contexts, setDEBIAN_FRONTENDand preferapt-getto avoid any interactive prompts:- "postCreateCommand": "apt update && apt install -y zsh && zsh" + "postCreateCommand": "DEBIAN_FRONTEND=noninteractive apt-get update && apt-get install -y zsh && zsh"
Add zsh installation if not present for the webContainer setup
Changes :
apt update && apt install -y zsh && zshSummary by CodeRabbit