Skeleton for drafts by MrgSub · Pull Request #1302 · Mail-0/Zero

MrgSub · 2025-06-13T18:53:05Z

READ CAREFULLY THEN REMOVE

Remove bullet points that are not relevant.

PLEASE REFRAIN FROM USING AI TO WRITE YOUR CODE AND PR DESCRIPTION. IF YOU DO USE AI TO WRITE YOUR CODE PLEASE PROVIDE A DESCRIPTION AND REVIEW IT CAREFULLY. MAKE SURE YOU UNDERSTAND THE CODE YOU ARE SUBMITTING USING AI.

Pull requests that do not follow these guidelines will be closed without review or comment.
If you use AI to write your PR description your pr will be close without review or comment.
If you are unsure about anything, feel free to ask for clarification.

Description

Please provide a clear description of your changes.

Type of Change

Please delete options that are not relevant.

🐛 Bug fix (non-breaking change which fixes an issue)
✨ New feature (non-breaking change which adds functionality)
💥 Breaking change (fix or feature with breaking changes)
📝 Documentation update
🎨 UI/UX improvement
🔒 Security enhancement
⚡ Performance improvement

Areas Affected

Please check all that apply:

Testing Done

Describe the tests you've done:

Unit tests added/updated
Integration tests added/updated
Manual testing performed
Cross-browser testing (if UI changes)
Mobile responsiveness verified (if UI changes)

Security Considerations

For changes involving data or authentication:

No sensitive data is exposed
Authentication checks are in place
Input validation is implemented
Rate limiting is considered (if applicable)

Checklist

I have read the CONTRIBUTING document
My code follows the project's style guidelines
I have performed a self-review of my code
I have commented my code, particularly in complex areas
I have updated the documentation
My changes generate no new warnings
I have added tests that prove my fix/feature works
All tests pass locally
Any dependent changes are merged and published

Additional Notes

Add any other context about the pull request here.

Screenshots/Recordings

Add screenshots or recordings here if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the project's license.

Summary by CodeRabbit

New Features
- Added a skeleton loader to display a placeholder UI while draft data is loading.
Style
- Improved formatting for cleaner and more consistent code appearance.

coderabbitai · 2025-06-13T18:53:10Z

Walkthrough

A new conditional rendering branch was added to the Draft component in mail-list.tsx to display a skeleton loader when draft data is unavailable. The skeleton mimics the draft item's layout using styled divs. Additionally, a minor formatting cleanup was performed in the Thread component's className assignment.

Changes

File(s)	Change Summary
apps/mail/components/mail/mail-list.tsx	Added skeleton loader UI for `Draft` component when data is missing; minor formatting cleanup in `Thread`.

Suggested reviewers

ahmetskilinc
needleXO

Poem

A draft with no data? Don’t fret, don’t fear—
A skeleton loader now brings comfort near!
With shimmering bars and a border so bright,
The inbox stays friendly, even out of sight.
🐇✨
Loading drafts gently, the rabbit hops on,
Until your real message is ready and drawn!

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

MrgSub · 2025-06-13T18:53:12Z

Hotfixing #1303
Skeleton for drafts #1302 👈 (View in Graphite)
Reset params onOpen compose #1301
staging

This stack of pull requests is managed by Graphite. Learn more about stacking.

MrgSub · 2025-06-13T18:55:05Z

Merge activity

Jun 13, 6:55 PM UTC: A user started a stack merge that includes this pull request via Graphite.
Jun 13, 6:56 PM UTC: Graphite rebased this pull request as part of a merge.
Jun 13, 6:58 PM UTC: @MrgSub merged this pull request with Graphite.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

apps/mail/components/mail/mail-list.tsx (1)
567-598: Improve accessibility & avoid duplicate layout code

Great call adding a visual placeholder. Two quick wins:

Expose a status landmark so assistive tech is aware something is loading.

Remove repeated layout by extracting the skeleton into its own small component – keeps the render branch concise and avoids future divergence.
-  if (!draft) {
-    return (
-      <div className="select-none py-1">
+  if (!draft) {
+    return (
+      <div
+        className="select-none py-1 animate-pulse"
+        role="status"
+        aria-label="Loading draft"
+      >
         ...
       </div>
     );
   }
If you move the internal markup into e.g. DraftSkeleton, the Draft component stays focused on logic and the visual skeleton can be reused elsewhere if needed.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 20fe4ae and 17d2b7a.

📒 Files selected for processing (1)

apps/mail/components/mail/mail-list.tsx (3 hunks)

🔇 Additional comments (2)

apps/mail/components/mail/mail-list.tsx (2)

45-45: Import looks good

Skeleton is now correctly imported from the shared UI module.
No further action needed.

442-442: Minor, non-blocking change

The class list on the <span> was adjusted. No functional impact observed, so nothing to flag here.

This was referenced Jun 13, 2025

Reset params onOpen compose #1301

Merged

Hotfixing #1303

Merged

MrgSub marked this pull request as ready for review June 13, 2025 18:54

graphite-app bot assigned MrgSub Jun 13, 2025

MrgSub changed the base branch from 06-11-reset_params_onopen_compose to graphite-base/1302 June 13, 2025 18:55

MrgSub changed the base branch from graphite-base/1302 to staging June 13, 2025 18:55

Skeleton for drafts

17d2b7a

MrgSub force-pushed the 06-11-skeleton_for_drafts branch from fdd839e to 17d2b7a Compare June 13, 2025 18:56

coderabbitai bot reviewed Jun 13, 2025

View reviewed changes

MrgSub merged commit ece0f15 into staging Jun 13, 2025
2 checks passed

MrgSub deleted the 06-11-skeleton_for_drafts branch June 13, 2025 18:58

This was referenced Jun 17, 2025

Delete Draft #1246

Closed

connect the draft to the thread #1381

Merged

This was referenced Jun 26, 2025

feat: Draft mail list timming display added #1501

Merged

feat: add shimmer loading effect and starred mail section #1589

Closed

coderabbitai bot mentioned this pull request Aug 11, 2025

fix: remove primary border from draft list and overflow visible #1984

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

Skeleton for drafts#1302

Skeleton for drafts#1302
MrgSub merged 1 commit intostagingfrom
06-11-skeleton_for_drafts

MrgSub commented Jun 13, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jun 13, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

MrgSub commented Jun 13, 2025 •

edited

Loading

Uh oh!

MrgSub commented Jun 13, 2025 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Comments

Conversation

MrgSub commented Jun 13, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

READ CAREFULLY THEN REMOVE

Description

Type of Change

Areas Affected

Testing Done

Security Considerations

Checklist

Additional Notes

Screenshots/Recordings

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Suggested reviewers

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

MrgSub commented Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MrgSub commented Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

MrgSub commented Jun 13, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jun 13, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

MrgSub commented Jun 13, 2025 •

edited

Loading

MrgSub commented Jun 13, 2025 •

edited

Loading