Fix: Arrow-keys focus on background instead of modal - Live Website (Issue #1371)

[omraval18]

Description

• Fixes (Arrow-keys focus on background instead of modal - Live Website #1371)
• When Command Palette is Opened and you scroll via arrow down the Email List also listens to this Event and scroll Emails in Background

---

Type of Change

• 🐛 Bug fix (non-breaking change which fixes an issue)

Areas Affected

Please check all that apply:

• Email Integration (Gmail, IMAP, etc.)
• User Interface/Experience
• Authentication/Authorization
• Data Storage/Management
• API Endpoints
• Documentation
• Testing Infrastructure
• Development Workflow
• Deployment/Infrastructure

Testing Done

Describe the tests you've done:

• Unit tests added/updated
• Integration tests added/updated
• Manual testing performed
• Cross-browser testing (if UI changes)
• Mobile responsiveness verified (if UI changes)

Security Considerations

For changes involving data or authentication:

• No sensitive data is exposed
• Authentication checks are in place
• Input validation is implemented
• Rate limiting is considered (if applicable)

Checklist

• I have read the CONTRIBUTING document
• My code follows the project's style guidelines
• I have performed a self-review of my code
• I have commented my code, particularly in complex areas
• I have updated the documentation
• My changes generate no new warnings
• I have added tests that prove my fix/feature works
• All tests pass locally
• Any dependent changes are merged and published

---

By submitting this pull request, I confirm that my contribution is made under the terms of the project's license.

Summary by CodeRabbit

• Bug Fixes
  • Prevented mail navigation keyboard shortcuts from interfering when the command palette is open.
  • Ensured keyboard navigation state resets when the command palette is activated for a smoother user experience.

[coderabbitai]

Walkthrough

The useMailNavigation hook was updated to recognize when the command palette is open. Keyboard navigation hotkeys are now disabled while the command palette is active, and internal navigation state is reset upon opening the palette. The implementation uses the useCommandPalette hook to track the palette's state.

Changes

File(s)	Change Summary
apps/mail/hooks/use-mail-navigation.ts	Integrated command palette state awareness; disabled navigation hotkeys and reset state when active.

Poem

In the warren of mail, where hotkeys once flew,
Now they pause when the palette comes into view.
No more hopping through threads while commands are in play—
The rabbit sits patient, awaiting the way.
Keyboard and palette, in harmony dwell,
Bringing smooth navigation, as all rabbits tell!

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

apps/mail/hooks/use-mail-navigation.ts (1)

198-203: Fix formatting inconsistencies in hotkey configurations.

The hotkey configurations have inconsistent spacing around the options objects, which affects code readability and consistency.

Apply this diff to fix the formatting:

-  useHotkeys('j', handleArrowDown,{enabled: !isCommandPaletteOpen });
-  useHotkeys('Enter', handleEnter, { preventDefault: true,enabled: !isCommandPaletteOpen });
-  useHotkeys('Escape', handleEscape, { preventDefault: true,enabled: !isCommandPaletteOpen });
+  useHotkeys('j', handleArrowDown, { enabled: !isCommandPaletteOpen });
+  useHotkeys('Enter', handleEnter, { preventDefault: true, enabled: !isCommandPaletteOpen });
+  useHotkeys('Escape', handleEscape, { preventDefault: true, enabled: !isCommandPaletteOpen });

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c76852f and 5237d75.

📒 Files selected for processing (1)

• apps/mail/hooks/use-mail-navigation.ts (5 hunks)

🔇 Additional comments (5)

apps/mail/hooks/use-mail-navigation.ts (5)

1-1: LGTM: Import statement is correct.

The import for useCommandPalette is properly added to access the command palette's open state.

---

26-26: LGTM: Hook usage is correct.

Properly destructuring the open property as isCommandPaletteOpen from the useCommandPalette hook for better readability.

---

244-244: LGTM: Early return prevents unintended navigation.

The early return when the command palette is open effectively prevents repeated arrow key events from affecting mail navigation, which directly addresses the reported bug.

---

272-272: LGTM: Dependency array correctly updated.

Adding isCommandPaletteOpen to the dependency array ensures the keydown event listener is properly updated when the command palette state changes.

---

274-278: LGTM: Keyboard state reset enhances user experience.

Resetting keyboardActiveRef.current when the command palette opens ensures that keyboard navigation state is properly cleared, preventing any residual navigation state from interfering with the command palette interaction.