Fixes

[MrgSub]

READ CAREFULLY THEN REMOVE

Remove bullet points that are not relevant.

PLEASE REFRAIN FROM USING AI TO WRITE YOUR CODE AND PR DESCRIPTION. IF YOU DO USE AI TO WRITE YOUR CODE PLEASE PROVIDE A DESCRIPTION AND REVIEW IT CAREFULLY. MAKE SURE YOU UNDERSTAND THE CODE YOU ARE SUBMITTING USING AI.

• Pull requests that do not follow these guidelines will be closed without review or comment.
• If you use AI to write your PR description your pr will be close without review or comment.
• If you are unsure about anything, feel free to ask for clarification.

Description

Please provide a clear description of your changes.

---

Type of Change

Please delete options that are not relevant.

• 🐛 Bug fix (non-breaking change which fixes an issue)
• ✨ New feature (non-breaking change which adds functionality)
• 💥 Breaking change (fix or feature with breaking changes)
• 📝 Documentation update
• 🎨 UI/UX improvement
• 🔒 Security enhancement
• ⚡ Performance improvement

Areas Affected

Please check all that apply:

• Email Integration (Gmail, IMAP, etc.)
• User Interface/Experience
• Authentication/Authorization
• Data Storage/Management
• API Endpoints
• Documentation
• Testing Infrastructure
• Development Workflow
• Deployment/Infrastructure

Testing Done

Describe the tests you've done:

• Unit tests added/updated
• Integration tests added/updated
• Manual testing performed
• Cross-browser testing (if UI changes)
• Mobile responsiveness verified (if UI changes)

Security Considerations

For changes involving data or authentication:

• No sensitive data is exposed
• Authentication checks are in place
• Input validation is implemented
• Rate limiting is considered (if applicable)

Checklist

• I have read the CONTRIBUTING document
• My code follows the project's style guidelines
• I have performed a self-review of my code
• I have commented my code, particularly in complex areas
• I have updated the documentation
• My changes generate no new warnings
• I have added tests that prove my fix/feature works
• All tests pass locally
• Any dependent changes are merged and published

Additional Notes

Add any other context about the pull request here.

Screenshots/Recordings

Add screenshots or recordings here if applicable.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the project's license.

Summary by CodeRabbit

• Bug Fixes

  • Improved iframe height calculation for email content, preventing incorrect sizing when content is empty.
  • Corrected toast notifications for enabling/disabling auto-labeling, ensuring accurate feedback.

• Chores

  • Cleaned up unused imports and whitespace in email display components.
  • Removed fallback UI for email content loading.
  • Eliminated unused error handling for image proxying.

• Style

  • Minor formatting improvements to localization strings for consistency.

• Database

  • Updated user settings defaults and added a comprehensive database migration snapshot.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This update introduces code cleanups, minor formatting adjustments, and a database migration. Unused imports and error handlers are removed, localization strings are refined, and function calls are simplified. The database migration updates default user settings and adds a new schema snapshot. No changes are made to public API signatures or core logic.

Changes

File(s)	Change Summary
apps/mail/components/mail/mail-display.tsx	Removed unused imports, cleaned up whitespace and formatting in printMail template, no logic changes.
apps/mail/components/mail/mail-iframe.tsx	Removed loading state and fallback UI; improved iframe height calculation with early return on empty body.
apps/mail/components/mail/mail.tsx	Simplified toast.promise usage by passing mutation functions directly instead of invoking them.
apps/mail/lib/email-utils.client.tsx	Removed onerror handler for proxied images, eliminating fallback to original src on load failure.
apps/mail/locales/en.json	Adjusted UI strings: changed "App Theme" to "Toggle Theme", added spaces after colons in label strings.
apps/server/src/db/migrations/0030_blue_grandmaster.sql	Altered default value of user settings column to a comprehensive JSONB object with categories and prefs.
apps/server/src/db/migrations/meta/0030_snapshot.json	Added a new migration snapshot detailing the schema for all mail-related tables and relationships.
apps/server/src/db/migrations/meta/_journal.json	Appended a new migration entry for the "0030_blue_grandmaster" migration.

Sequence Diagram(s)

sequenceDiagram
  participant User
  participant AutoLabelingSettings
  participant toast
  participant EnableBrain/DisableBrain

  User->>AutoLabelingSettings: Click enable/disable brain
  AutoLabelingSettings->>toast: toast.promise(EnableBrain/DisableBrain)
  toast->>EnableBrain/DisableBrain: Invoke mutation function
  EnableBrain/DisableBrain-->>toast: Promise resolved/rejected
  toast-->>AutoLabelingSettings: Show success/error/finally UI

Loading

Possibly related PRs

• Staging #776: Both PRs modify the usage and invocation of the EnableBrain function, affecting how it is passed to toast.promise.
• IFrame Performance Improv #1256: Both PRs change loading state handling and fallback UI in the MailIframe component, but in opposite directions.
• Hotfix #1390: Both PRs modify mail-iframe.tsx, with this PR simplifying logic and the related PR refactoring rendering with Blob URLs and sandboxing.

Suggested reviewers

• nizzyabi

Poem

A rabbit hops through code so neat,
Trimming imports, making things complete.
Settings and snapshots, all in a row,
With themes to toggle and schemas to show.
The database hums, the UI is spry—
Another clean patch, as time hops by!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c5d5479 and 8a39e61.

📒 Files selected for processing (8)

• apps/mail/components/mail/mail-display.tsx (12 hunks)
• apps/mail/components/mail/mail-iframe.tsx (2 hunks)
• apps/mail/components/mail/mail.tsx (2 hunks)
• apps/mail/lib/email-utils.client.tsx (0 hunks)
• apps/mail/locales/en.json (2 hunks)
• apps/server/src/db/migrations/0030_blue_grandmaster.sql (1 hunks)
• apps/server/src/db/migrations/meta/0030_snapshot.json (1 hunks)
• apps/server/src/db/migrations/meta/_journal.json (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[MrgSub]

• Fixes #1397 👈 (View in Graphite)
• staging

This stack of pull requests is managed by Graphite. Learn more about stacking.

[MrgSub]

Merge activity

• Jun 20, 6:57 AM UTC: A user started a stack merge that includes this pull request via Graphite.
• Jun 20, 6:57 AM UTC: @MrgSub merged this pull request with Graphite.