fix: theme toggle label, session stability #1408#1411
Closed
Sompalkar wants to merge 3 commits intoMail-0:stagingfrom
Closed
fix: theme toggle label, session stability #1408#1411Sompalkar wants to merge 3 commits intoMail-0:stagingfrom
Sompalkar wants to merge 3 commits intoMail-0:stagingfrom
Conversation
Contributor
WalkthroughThe changes refine session and user ID checks across multiple components and hooks, ensuring actions are only performed if a valid user ID exists in the session. Additionally, the theme toggle UI text in the navigation user menu is updated to dynamically display "Light Theme" or "Dark Theme" based on the current theme. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant NavUserComponent
participant ThemeManager
User->>NavUserComponent: Clicks theme toggle
NavUserComponent->>ThemeManager: Get current theme
ThemeManager-->>NavUserComponent: Returns 'dark' or 'light'
NavUserComponent-->>User: Displays "Light Theme" or "Dark Theme"
sequenceDiagram
participant User
participant Component
participant AuthProvider
User->>Component: Initiates action (e.g., upgrade, navigate)
Component->>Component: Check session?.user?.id
alt user id exists
Component->>Component: Proceed with action (navigate/upgrade)
else user id missing
Component->>AuthProvider: Trigger Google sign-in with callback
end
Assessment against linked issues
Assessment against linked issues: Out-of-scope changes
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
MrgSub
reviewed
Jun 22, 2025
Collaborator
|
You have two open PRs with similar changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
🎨 UI Improvement – Theme Toggle (Fixes #1408)
Previously, the theme toggle button just said "App Theme", which wasn’t very informative.
Now, it dynamically updates to show "Light Theme" or "Dark Theme", depending on what’s currently active.
This small change makes it much clearer what clicking the button will do — a simple win for user experience.
🛠️ Session Stability Fixes
There were some issues where the app would crash or behave oddly if the session wasn’t available yet — especially noticeable on first load or when the user was logged out.
To fix this, I’ve added optional chaining (?.) throughout the code to safely access session data.
This change touches several key parts of the app, like:
use-settings.ts
client-providers.tsx
use-drafts.ts
create-email.tsx
Pricing pages
These updates make the app much more resilient and prevent unexpected crashes due to missing session data.
🖥️ Windows CLI Compatibility – sync Command Fix
Running pnpm nizzy sync on Windows was throwing spawn pnpm ENOENT errors.
Turns out, Node’s child_process.spawn doesn’t use the system shell by default, and on Windows, tools like pnpm and npx need it to resolve properly (since they’re .cmd files).
Updated the runCommand utility in packages/cli/src/utils.ts to use { shell: true }.
Now, it works seamlessly on Windows and other platforms without error.
Summary by CodeRabbit