fix the details popover overflow#1436
Merged
MrgSub merged 2 commits intoMail-0:stagingfrom Jun 23, 2025
Merged
Conversation
Contributor
WalkthroughThe update adjusts the CSS class names for the Changes
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/mail/components/mail/mail-display.tsx (1)
1460-1460: LGTM! Overflow fix looks correct with minor formatting nitpick.The CSS changes effectively address the popover overflow issue:
overflow-autoenables scrolling for long contentflexproperly establishes the flex container for child elements- Removing
align-items-startis correct since it requires a flex container- Increased padding improves visual spacing
Minor formatting issue: there are two spaces between
p-4andtext-left.- className="flex dark:bg-panelDark w-[420px] rounded-lg border p-4 text-left shadow-lg overflow-auto" + className="flex dark:bg-panelDark w-[420px] rounded-lg border p-4 text-left shadow-lg overflow-auto"
MrgSub
approved these changes
Jun 23, 2025
krakenftw
pushed a commit
to krakenftw/Zero
that referenced
this pull request
Jun 24, 2025
34 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix the text overflow at details popover
Type of Change
Please delete options that are not relevant.
Areas Affected
Please check all that apply:
Testing Done
Describe the tests you've done:
Security Considerations
For changes involving data or authentication:
Checklist
Additional Notes
Add any other context about the pull request here.
Screenshots/Recordings
By submitting this pull request, I confirm that my contribution is made under the terms of the project's license.
Summary by CodeRabbit