Skip to content

Comments

feat: move "Get Started" button to HomeContent for mobile visibility#1516

Merged
MrgSub merged 1 commit intoMail-0:stagingfrom
samrathreddy:get-started-button-responsive
Jun 27, 2025
Merged

feat: move "Get Started" button to HomeContent for mobile visibility#1516
MrgSub merged 1 commit intoMail-0:stagingfrom
samrathreddy:get-started-button-responsive

Conversation

@samrathreddy
Copy link
Contributor

@samrathreddy samrathreddy commented Jun 27, 2025

Description

For mobile view, the "Get Started" button was removed from the Navigation component as its placement wasn't suitable, and it was added to the HomeContent component for a more intuitive and visually balanced layout.


Type of Change

Please delete options that are not relevant.

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature with breaking changes)
  • 📝 Documentation update
  • 🎨 UI/UX improvement
  • 🔒 Security enhancement
  • ⚡ Performance improvement

Areas Affected

Please check all that apply:

  • Email Integration (Gmail, IMAP, etc.)
  • User Interface/Experience
  • Authentication/Authorization
  • Data Storage/Management
  • API Endpoints
  • Documentation
  • Testing Infrastructure
  • Development Workflow
  • Deployment/Infrastructure

Testing Done

Describe the tests you've done:

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • Cross-browser testing (if UI changes)
  • Mobile responsiveness verified (if UI changes)

Security Considerations

For changes involving data or authentication:

  • No sensitive data is exposed
  • Authentication checks are in place
  • Input validation is implemented
  • Rate limiting is considered (if applicable)

Checklist

  • I have read the CONTRIBUTING document
  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in complex areas
  • I have updated the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix/feature works
  • All tests pass locally
  • Any dependent changes are merged and published

Additional Notes

Add any other context about the pull request here.

Screenshots/Recordings

Before:
Screenshot 2025-06-27 at 4 13 05 PM
Screenshot 2025-06-27 at 4 13 08 PM

After:
Screenshot 2025-06-27 at 4 12 39 PM
Screenshot 2025-06-27 at 4 12 43 PM


By submitting this pull request, I confirm that my contribution is made under the terms of the project's license.

Summary by CodeRabbit

  • New Features

    • Introduced a "Get Started" button on mobile screens with animated appearance; clicking it will either navigate to the inbox or prompt Google sign-in, displaying an error toast if login fails.
  • Refactor

    • Removed the "Get Started" button and its sign-in logic from the mobile navigation sheet header. The button is now only available in the main home content on mobile.

- (For mobile view) Removed the "Get Started" button from the Navigation component.
-  (For mobile view) Added the button to the HomeContent component.
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 27, 2025

Walkthrough

A mobile-only "Get Started" button with session-aware navigation and sign-in logic was added to the HomeContent component. Simultaneously, the same button and its logic were removed from the mobile navigation sheet header, consolidating sign-in and navigation actions within the home content area.

Changes

Files Change Summary
apps/mail/components/home/HomeContent.tsx Added a mobile-only "Get Started" button with session-based navigation and Google sign-in logic.
apps/mail/components/navigation.tsx Removed the "Get Started" button and its associated session/sign-in logic from the mobile navigation header.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant HomeContent
    participant Session
    participant Router
    participant AuthProvider
    participant Toast

    User->>HomeContent: Clicks "Get Started" (mobile)
    HomeContent->>Session: Check if session exists
    alt Session exists
        HomeContent->>Router: Navigate to "/mail/inbox"
    else No session
        HomeContent->>AuthProvider: Initiate Google sign-in (callback: "/mail")
        AuthProvider-->>HomeContent: Success or failure
        alt Sign-in fails
            HomeContent->>Toast: Show error toast
        end
    end
Loading

Possibly related PRs

Suggested labels

Low Priority

Suggested reviewers

  • ahmetskilinc
  • MrgSub

Poem

A button hops in, just for phones,
"Get Started" guides you, not alone.
If logged in, inbox you’ll see,
If not, Google’s sign-in spree.
Navigation’s cleaner, less to roam—
The rabbit’s code now feels like home!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3041531 and 24e16db.

📒 Files selected for processing (2)
  • apps/mail/components/home/HomeContent.tsx (3 hunks)
  • apps/mail/components/navigation.tsx (0 hunks)
💤 Files with no reviewable changes (1)
  • apps/mail/components/navigation.tsx
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: danteissaias
PR: Mail-0/Zero#902
File: apps/mail/components/connection/add.tsx:77-77
Timestamp: 2025-05-07T16:55:46.513Z
Learning: For the "Upgrade" link in AddConnectionDialog, using a proper <button> element instead of a <span> with onClick is recognized as an accessibility improvement but was deferred as out of scope in PR #902 (CSS variables PR).
🔇 Additional comments (3)
apps/mail/components/home/HomeContent.tsx (3)

36-36: LGTM: Import additions are appropriate

The new imports for useSession from auth-client and useNavigate from react-router are correctly added to support the session-aware navigation functionality.

Also applies to: 41-41


65-66: LGTM: Hook initializations follow React patterns

The hooks are properly initialized at the component level and will be used for the new mobile button functionality.


124-151: Well-implemented mobile-only button with session-aware navigation

The implementation demonstrates several good practices:

  • Proper mobile-only visibility using md:hidden
  • Smooth fade-in and slide-up animation with appropriate delay
  • Session-aware logic that navigates existing users to inbox or triggers sign-in for new users
  • Proper error handling with toast.promise
  • Consistent styling and motion patterns with the rest of the component

The conditional navigation logic correctly handles both authenticated and unauthenticated states, providing a seamless user experience.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Collaborator

@MrgSub MrgSub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep it in navigation for desktop

@samrathreddy
Copy link
Contributor Author

@MrgSub Can you please elaborate, Thank you.

Copy link
Collaborator

MrgSub commented Jun 27, 2025

I see it now, sorry long day. Thank you

@MrgSub MrgSub merged commit 59c18be into Mail-0:staging Jun 27, 2025
3 checks passed
@samrathreddy
Copy link
Contributor Author

@MrgSub Cool :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants