frontend: Settings: Adjust misalignments of placeholders#1531
frontend: Settings: Adjust misalignments of placeholders#1531MrgSub merged 2 commits intoMail-0:stagingfrom
Conversation
WalkthroughThe change updates the CSS classes for the Changes
Sequence Diagram(s)Assessment against linked issues
Assessment against linked issues: Out-of-scope changesSuggested labels
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
apps/mail/app/(routes)/settings/general/page.tsx (2)
210-212: Consider centering the label’s inline content explicitly
className="flex"switches the label’s display to flexbox but leavesalign-itemsat the defaultstretch.
If the text (or future inline elements) ends up taller than the parent, mis-vertical-alignment can re-appear. Guard against that now:-<FormLabel className="flex"> +<FormLabel className="flex items-center">A tiny tweak, but it future-proofs the layout.
234-236: Same centering concern applies hereReplicate the
items-centeraddition for consistency with the language field and to ensure both labels align identically:-<FormLabel className="flex"> +<FormLabel className="flex items-center">
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
apps/mail/app/(routes)/settings/general/page.tsx(3 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: danteissaias
PR: Mail-0/Zero#902
File: apps/mail/components/connection/add.tsx:77-77
Timestamp: 2025-05-07T16:55:46.513Z
Learning: For the "Upgrade" link in AddConnectionDialog, using a proper <button> element instead of a <span> with onClick is recognized as an accessibility improvement but was deferred as out of scope in PR #902 (CSS variables PR).
apps/mail/app/(routes)/settings/general/page.tsx (1)
Learnt from: retrogtx
PR: Mail-0/Zero#1468
File: apps/server/src/trpc/routes/mail.ts:331-331
Timestamp: 2025-06-28T03:56:09.351Z
Learning: In apps/server/src/trpc/routes/mail.ts, the user indicated they are not using ISO format for the scheduleAt parameter, despite the frontend code showing toISOString() usage in the ScheduleSendPicker component.
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
apps/mail/locales/pl.json (1)
363-363: Consider translating "Live Support" to Polish.Similar to other locale files, "Live Support" remains in English. If this should be localized, consider translating it to Polish (e.g., "Wsparcie na żywo").
🧹 Nitpick comments (1)
apps/mail/locales/es.json (1)
363-363: Consider translating "Live Support" to Spanish.The value "Live Support" remains in English within the Spanish locale file. If this is a brand term that should stay in English across all locales, this is correct. Otherwise, consider translating it to Spanish (e.g., "Soporte en Vivo").
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (23)
apps/mail/components/ui/nav-main.tsx(2 hunks)apps/mail/locales/ar.json(1 hunks)apps/mail/locales/ca.json(1 hunks)apps/mail/locales/cs.json(1 hunks)apps/mail/locales/de.json(1 hunks)apps/mail/locales/en.json(1 hunks)apps/mail/locales/es.json(1 hunks)apps/mail/locales/fa.json(1 hunks)apps/mail/locales/fr.json(1 hunks)apps/mail/locales/hi.json(1 hunks)apps/mail/locales/hu.json(1 hunks)apps/mail/locales/ja.json(1 hunks)apps/mail/locales/ko.json(1 hunks)apps/mail/locales/lv.json(1 hunks)apps/mail/locales/nl.json(1 hunks)apps/mail/locales/pl.json(1 hunks)apps/mail/locales/pt.json(1 hunks)apps/mail/locales/ru.json(1 hunks)apps/mail/locales/tr.json(1 hunks)apps/mail/locales/vi.json(1 hunks)apps/mail/locales/zh_CN.json(1 hunks)apps/mail/locales/zh_TW.json(1 hunks)package.json(1 hunks)
✅ Files skipped from review due to trivial changes (19)
- apps/mail/locales/nl.json
- apps/mail/locales/tr.json
- apps/mail/locales/de.json
- apps/mail/locales/fa.json
- apps/mail/locales/zh_CN.json
- apps/mail/locales/pt.json
- apps/mail/locales/cs.json
- apps/mail/locales/ca.json
- apps/mail/locales/hu.json
- apps/mail/locales/ja.json
- apps/mail/locales/fr.json
- apps/mail/locales/ru.json
- apps/mail/locales/ko.json
- apps/mail/locales/lv.json
- apps/mail/locales/zh_TW.json
- apps/mail/locales/en.json
- apps/mail/locales/vi.json
- apps/mail/locales/hi.json
- apps/mail/locales/ar.json
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: danteissaias
PR: Mail-0/Zero#902
File: apps/mail/components/connection/add.tsx:77-77
Timestamp: 2025-05-07T16:55:46.513Z
Learning: For the "Upgrade" link in AddConnectionDialog, using a proper <button> element instead of a <span> with onClick is recognized as an accessibility improvement but was deferred as out of scope in PR #902 (CSS variables PR).
package.json (1)
Learnt from: adiologydev
PR: Mail-0/Zero#871
File: docker-compose.yaml:36-46
Timestamp: 2025-05-04T20:00:52.180Z
Learning: The project uses a monorepo structure where Docker builds require the root context to access files throughout the repository. Changing build contexts for services like migrations would require significant restructuring.
🔇 Additional comments (4)
apps/mail/locales/es.json (1)
363-363: Verify this change aligns with the PR objectives.The PR is described as fixing "misalignments of placeholders" in Settings/General, but this change adds a navigation localization string. Please confirm this change belongs in this PR.
Likely an incorrect or invalid review comment.
package.json (1)
22-22: Verify this change belongs in this PR.This Docker command change appears unrelated to the stated PR objectives about fixing placeholder alignment issues in Settings/General.
Likely an incorrect or invalid review comment.
apps/mail/components/ui/nav-main.tsx (2)
193-196: LGTM! Proper internationalization implementation.The replacement of hardcoded "Live Support" text with the localized string using
t('navigation.sidebar.livesupport')follows the correct internationalization pattern.
193-196: Verify this change aligns with the PR objectives.This internationalization change appears unrelated to the stated PR objectives about fixing "misalignments of placeholders" in Settings/General. Please confirm this change belongs in this PR.
Likely an incorrect or invalid review comment.
SinghaAnirban005
force-pushed
the
bug/general
branch
from
86b1a5a to
1aed17e
Compare
SinghaAnirban005
force-pushed
the
bug/general
branch
from
1aed17e to
eab7c4b
Compare
|
@MrgSub @ahmetskilinc |
2 participants
Description
This PR fixes the alignment of the "default email alias" placeholder under Settings/General
fixes #1530
Type of Change
Please delete options that are not relevant.
Areas Affected
Please check all that apply:
Testing Done
Describe the tests you've done:
Security Considerations
For changes involving data or authentication:
Checklist
Screenshots/Recordings
By submitting this pull request, I confirm that my contribution is made under the terms of the project's license.
Summary by CodeRabbit