fix foreground / background colour sync issues by retrogtx · Pull Request #1593 · Mail-0/Zero

retrogtx · 2025-07-02T09:01:04Z

before:
https://github.com/user-attachments/assets/151e6464-a193-400a-9eae-921028568b74

after:
https://github.com/user-attachments/assets/678220f7-da56-4f3a-895c-38dfe7e5b7fc

coderabbitai · 2025-07-02T09:01:12Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

greptile-apps

PR Summary

Implements improved color contrast handling for email rendering with dynamic theme support.

Added configurable contrast ratio settings in apps/mail/lib/email-utils.ts with new options parameter for fixNonReadableColors function
Removed 'all: initial' reset in apps/server/src/lib/email-processor.ts to prevent style inheritance issues
Implemented shadow DOM color processing in apps/mail/components/mail/mail-content.tsx using requestAnimationFrame for performance
Added Geist font integration and consistent typography settings for better readability
Enhanced theme-based color synchronization for text and backgrounds with proper hover states

_{3 files reviewed, 2 comments}
_{Edit PR Review Bot Settings | Greptile}

greptile-apps · 2025-07-02T09:01:34Z

apps/mail/lib/email-utils.ts

      const blendedText =
        textColor.alpha() < 1 ? effectiveBg.mix(textColor, effectiveBg.alpha()) : textColor;


logic: Potential bug: effectiveBg.alpha() used for mix ratio, but should likely be textColor.alpha()

greptile-apps · 2025-07-02T09:01:39Z

apps/mail/components/mail/mail-content.tsx

+      });
+    };
+
+    requestAnimationFrame(applyFix);


logic: rAF callback should be cleaned up in useEffect return function to prevent memory leaks

fix foreground / background colour sync issues

0ddecb9

graphite-app bot assigned retrogtx Jul 2, 2025

greptile-apps bot reviewed Jul 2, 2025

View reviewed changes

retrogtx mentioned this pull request Jul 2, 2025

new email renderer #1584

Merged

ahmetskilinc merged commit e7a5ced into Mail-0:07-01-new_email_renderer Jul 2, 2025
4 checks passed

ahmetskilinc pushed a commit that referenced this pull request Jul 2, 2025

fix foreground / background colour sync issues (#1593)

3fabaef

ahmetskilinc pushed a commit that referenced this pull request Jul 4, 2025

fix foreground / background colour sync issues (#1593)

0885d79

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

fix foreground / background colour sync issues#1593

fix foreground / background colour sync issues#1593
ahmetskilinc merged 1 commit intoMail-0:07-01-new_email_rendererfrom
retrogtx:fix-colour

retrogtx commented Jul 2, 2025

Uh oh!

coderabbitai bot commented Jul 2, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

greptile-apps bot left a comment

Uh oh!

greptile-apps bot Jul 2, 2025

Uh oh!

greptile-apps bot Jul 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		const blendedText =
		textColor.alpha() < 1 ? effectiveBg.mix(textColor, effectiveBg.alpha()) : textColor;

Uh oh!

Comments

Conversation

retrogtx commented Jul 2, 2025

Uh oh!

coderabbitai bot commented Jul 2, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

Uh oh!

greptile-apps bot Jul 2, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jul 2, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

CodeRabbit Configuration File (`.coderabbit.yaml`)