Skip to content

fixes to email rendering #1646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahmetskilinc merged 3 commits into from
Jul 7, 2025
Merged

fixes to email rendering #1646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a9221d0
fixes to email rendering
ahmetskilinc Jul 5, 2025
db3953a
removes title tag
ahmetskilinc Jul 5, 2025
856d345
graphite recommendations
ahmetskilinc Jul 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/mail/components/mail/mail-content.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ export function MailContent({ id, html, senderEmail }: MailContentProps) {
</button>
</div>
)}
<div ref={hostRef} className={cn('mail-content w-full flex-1 overflow-hidden')} />
<div ref={hostRef} className={cn('mail-content w-full flex-1 overflow-hidden px-4')} />
</>
);
}
16 changes: 8 additions & 8 deletions apps/server/src/lib/email-processor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,12 @@ export function processEmailHtml({ html, shouldLoadImages, theme }: ProcessEmail
let hasBlockedImages = false;

const sanitizeConfig: sanitizeHtml.IOptions = {
allowedTags: sanitizeHtml.defaults.allowedTags.concat(['img']),
allowedAttributes: false,
allowedTags: sanitizeHtml.defaults.allowedTags.concat(['img', 'title']),
allowedAttributes: {
img: ['src', 'alt'],
a: ['href', 'target', 'rel'],
'*': ['style', 'class', 'width', 'height', 'colspan', 'rowspan'],
},
allowedSchemes: shouldLoadImages
? ['http', 'https', 'mailto', 'tel', 'data', 'cid', 'blob']
: ['http', 'https', 'mailto', 'tel', 'cid'],
Expand Down Expand Up @@ -47,6 +51,8 @@ export function processEmailHtml({ html, shouldLoadImages, theme }: ProcessEmail

const $ = cheerio.load(sanitized);

$('title').remove();

$('img[width="1"][height="1"]').remove();
$('img[width="0"][height="0"]').remove();

Expand Down Expand Up @@ -112,12 +118,6 @@ export function processEmailHtml({ html, shouldLoadImages, theme }: ProcessEmail
border-collapse: collapse;
}

.gmail_quote {
margin: 1em 0;
padding-left: 1em;
border-left: 1px solid ${theme === 'dark' ? '#666' : '#ccc'};
}

::selection {
background: #b3d4fc;
text-shadow: none;
Expand Down