fix(compose): avoid modal trap by removing Dialog wrapper#1749
fix(compose): avoid modal trap by removing Dialog wrapper#1749bas3line wants to merge 3 commits intoMail-0:stagingfrom
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
WalkthroughThe compose mail page was refactored to remove modal dialog UI components and instead use a full-page container. The loader logic was clarified by assigning query parameters to variables and returning an explicit object. Comments were added to explain the changes and address accessibility and UX considerations. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant ComposePage
participant clientLoader
participant CreateEmail
User->>ComposePage: Navigates to /mail/compose
ComposePage->>clientLoader: Loads query parameters
clientLoader-->>ComposePage: Returns extracted parameters
ComposePage->>CreateEmail: Renders with initial props
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (2)📓 Common learningsapps/mail/app/(routes)/mail/compose/page.tsx (6)🔇 Additional comments (4)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
cubic reviewed 1 file and found no issues. Review PR in cubic.dev.
Bug ReportName: Missing Focus Management in Compose Page Comments? Email us. Your free trial ends in 5 days. |
|
this page isnt used anymore. closing |
3 participants
Description
It improves screen reader support and navigation by replacing modal with a full screen layout. this also avoids focus traps and aligns better with expected behavior for a standalone compose screen
Type of Change
Please delete options that are not relevant.
Areas Affected
Please check all that apply:
Testing Done
Describe the tests you've done:
Security Considerations
For changes involving data or authentication:
Checklist
Additional Notes
This change replaces the Compose modal with a full-page layout to improve accessibility and usability.
Dialog was removed to avoid keyboard traps and improve screen reader support.
Redirect logic is preserved and tested for login + mailto handling.
By submitting this pull request, I confirm that my contribution is made under the terms of the project's license.
Summary by CodeRabbit
New Features
Refactor