Skip to content

Comments

Fix: landing page footer responsive layout on mobile#1777

Merged
ahmetskilinc merged 5 commits intoMail-0:stagingfrom
ayushsharma74:fix/landing-footer-responsive-layout-on-mobile
Aug 25, 2025
Merged

Fix: landing page footer responsive layout on mobile#1777
ahmetskilinc merged 5 commits intoMail-0:stagingfrom
ayushsharma74:fix/landing-footer-responsive-layout-on-mobile

Conversation

@ayushsharma74
Copy link
Contributor

@ayushsharma74 ayushsharma74 commented Jul 21, 2025

Description

Fixes #1430

The changes make the landing page footer fully responsive and visible on all screens by updating its layout and applying correct Tailwind classes for mobile breakpoints.


Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • 🎨 UI/UX improvement

Areas Affected

Please check all that apply:

  • Email Integration (Gmail, IMAP, etc.)
  • User Interface/Experience
  • Authentication/Authorization
  • Data Storage/Management
  • API Endpoints
  • Documentation
  • Testing Infrastructure
  • Development Workflow
  • Deployment/Infrastructure

Testing Done

Describe the tests you've done:

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • Cross-browser testing (if UI changes)
  • Mobile responsiveness verified (if UI changes)

Security Considerations

For changes involving data or authentication:

  • No sensitive data is exposed
  • Authentication checks are in place
  • Input validation is implemented
  • Rate limiting is considered (if applicable)

Checklist

  • I have read the CONTRIBUTING document
  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in complex areas
  • I have updated the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix/feature works
  • All tests pass locally
  • Any dependent changes are merged and published

Additional Notes

Add any other context about the pull request here.

Screenshots/Recordings

Mobile Screen Layout

localhost_3000_(iPhone 12 Pro)

Tablet Layout

localhost_3000_(iPad Air)

Big Screen Layout

localhost_3000_(Nest Hub Max) (1) ---

By submitting this pull request, I confirm that my contribution is made under the terms of the project's license.


Summary by cubic

Fixed the landing page footer layout so it displays correctly and remains fully visible on all mobile screen sizes.

  • Bug Fixes
    • Updated Tailwind classes and layout to ensure footer elements stack and resize properly on mobile devices.

Summary by CodeRabbit

  • Style
    • Improved footer layout and spacing for better responsiveness across screen sizes.
    • Adjusted font sizes and alignment for enhanced readability on all devices.
    • Updated spacing and stacking of copyright and legal links for a cleaner appearance.
    • Ensured legal links do not wrap, maintaining consistent presentation.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 21, 2025

Walkthrough

The Footer component was refactored to ensure it remains visible and properly styled across all screen sizes. Responsive layout and typography classes were updated, flex direction and spacing were adjusted for small and medium screens, and text sizes were made adaptive. No changes were made to the component's exported interface.

Changes

File(s) Change Summary
apps/mail/components/home/footer.tsx Refactored Footer layout for responsive visibility and spacing; updated flex, margin, and font classes.

Estimated code review effort

1 (~5 minutes)

Suggested labels

Low Priority

Poem

A footer once vanished, now stands proud and neat,
On screens big and small, it won’t miss a beat.
With flex and with margin, it stretches with grace,
Bringing info and links to their proper place.
Hooray for the code that keeps feet on the ground—
Now the landing page’s footer is always around!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 718b303 and e6ac504.

📒 Files selected for processing (1)
  • apps/mail/components/home/footer.tsx (10 hunks)
🔇 Additional comments (9)
apps/mail/components/home/footer.tsx (9)

29-29: LGTM: Footer now visible on mobile devices.

The removal of hidden md:flex classes and addition of responsive margin classes ensures the footer displays properly on all screen sizes, directly addressing the PR objective.


83-83: Good responsive margin adjustment.

The responsive top margin (mt-10 md:mt-52) appropriately reduces spacing on mobile while maintaining the intended layout on larger screens.


84-84: Excellent responsive layout pattern.

The flex-col md:flex-row approach correctly stacks content vertically on mobile for better usability while maintaining the horizontal layout on larger screens.


85-85: Proper vertical spacing for mobile layout.

The mb-10 md:mb-0 classes provide appropriate separation when content stacks vertically on mobile while avoiding unnecessary spacing on desktop.


123-123: Appropriate responsive gap sizing.

The gap-5 md:gap-10 classes optimize spacing for mobile while maintaining comfortable separation on larger screens.


135-135: Good responsive typography scaling.

The consistent text-sm md:text-base pattern across all navigation links appropriately scales text for different screen sizes. Consider testing that text-sm (14px) maintains sufficient readability on mobile devices for accessibility compliance.

Also applies to: 140-140, 157-157, 167-167, 177-177, 189-189, 194-194, 204-204


214-214: Smart mobile layout with reversed stacking.

The flex-col-reverse md:flex-row gap-3 approach places legal links above copyright on mobile (better UX) while maintaining the horizontal desktop layout.


218-218: Good spacing addition for legal links.

The gap-4 class provides consistent and appropriate spacing between legal navigation links.


221-221: Excellent addition of text-nowrap for legal links.

The text-nowrap classes prevent awkward line breaks in legal link text like "Terms & Conditions," maintaining a professional appearance across all screen sizes.

Also applies to: 229-229, 237-237

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cubic analysis

No issues found across 1 file. Review in cubic

@jazzberry-ai
Copy link

jazzberry-ai bot commented Jul 22, 2025

Bug Report

Name Severity Example test case Description
Footer Overlap on Mobile Medium View the footer on a short mobile screen. The mt-10 class on the footer might cause it to overlap with the content above it, especially on screens with less content.
Text Wrapping Issues Low View the footer on a narrow mobile screen with long link texts. The text-nowrap class added to the links might cause text overflow on very narrow screens, making the links unreadable.
Gap Discrepancies Low View the footer on both mobile and desktop screens. The gap-5 md:gap-10 class may not be appropriate for all screen sizes, leading to visual inconsistencies.

Comments? Email us. Your free trial ends in 7 days.

@jazzberry-ai
Copy link

jazzberry-ai bot commented Jul 27, 2025

Bug Report

Name Severity Example test case Description
Horizontal Overflow in Footer on Mobile Due to text-nowrap High View the footer on a mobile device or in a narrow viewport. The 'About', 'Terms & Conditions', and 'Privacy Policy' links will not wrap, causing horizontal overflow. The text-nowrap class is applied to the 'About', 'Terms & Conditions', and 'Privacy Policy' links in the footer. This prevents the text from wrapping on smaller screens, leading to horizontal overflow and a broken layout. Removing text-nowrap resolves the issue.

Comments? Email us. Your free trial ends in 2 days.

@ayushsharma74
Copy link
Contributor Author

@MrgSub ready for review

@ahmetskilinc ahmetskilinc merged commit e30e7c9 into Mail-0:staging Aug 25, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Footer of landing page disappears on smaller screens

2 participants