Skip to content

Comments

Fix WorkflowRunner to use this.env instead of global env#1857

Merged
MrgSub merged 1 commit intostagingfrom
ZEROFix_WorkflowRunner_to_use_this.env_instead_of_global_env
Jul 29, 2025
Merged

Fix WorkflowRunner to use this.env instead of global env#1857
MrgSub merged 1 commit intostagingfrom
ZEROFix_WorkflowRunner_to_use_this.env_instead_of_global_env

Conversation

@MrgSub
Copy link
Collaborator

@MrgSub MrgSub commented Jul 29, 2025

Fix WorkflowRunner to use instance environment variables

Description

This PR fixes an issue in the WorkflowRunner class where global env was being used instead of the instance's this.env. All references to the global env variable have been replaced with this.env to ensure proper access to environment variables within the Durable Object context.

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)

Areas Affected

  • Email Integration (Gmail, IMAP, etc.)

Testing Done

  • Manual testing performed

Checklist

  • I have performed a self-review of my code
  • My changes generate no new warnings
  • All tests pass locally

Additional Notes

This change ensures that the WorkflowRunner correctly accesses environment variables through the instance's context rather than relying on the global environment, which could lead to undefined behavior in a Cloudflare Workers environment.


By submitting this pull request, I confirm that my contribution is made under the terms of the project's license.

Summary by CodeRabbit

  • Refactor
    • Updated internal handling of environment variables to improve consistency and maintainability. No changes to user-facing features or behavior.

@jazzberry-ai
Copy link

jazzberry-ai bot commented Jul 29, 2025

This repository is associated with MrgSub whose free trial has ended. Subscribe at jazzberry.ai.
If this is an error contact us at support@jazzberry.ai.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 29, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

All direct references to the global env object from cloudflare:workers have been removed from the WorkflowRunner class in favor of accessing environment bindings via the instance property this.env. The import statement for env is eliminated, and all usages are updated accordingly. No logic or control flow is changed.

Changes

Cohort / File(s) Change Summary
Environment Reference Refactor
apps/server/src/pipelines.ts
Replaced all references to the global env object with this.env within the WorkflowRunner class. Removed the import of env from cloudflare:workers. No logic or control flow modifications.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Possibly related PRs

Suggested labels

design

Poem

In pipelines’ code, the winds have blown,
From global env, to instance grown.
No logic lost, no flow askew,
Just cleaner ways to pass things through.
The future’s bright, the bindings neat—
This refactor’s simply... elite. 🚀


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d043eaa and 0a25f68.

📒 Files selected for processing (1)
  • apps/server/src/pipelines.ts (11 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ZEROFix_WorkflowRunner_to_use_this.env_instead_of_global_env

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@MrgSub MrgSub marked this pull request as ready for review July 29, 2025 17:34
Copy link
Collaborator Author

MrgSub commented Jul 29, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Copy link
Collaborator Author

MrgSub commented Jul 29, 2025

Merge activity

  • Jul 29, 5:34 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jul 29, 5:34 PM UTC: @MrgSub merged this pull request with Graphite.

@MrgSub MrgSub merged commit 4c86d59 into staging Jul 29, 2025
7 of 8 checks passed
@MrgSub MrgSub deleted the ZEROFix_WorkflowRunner_to_use_this.env_instead_of_global_env branch July 29, 2025 17:34
@coderabbitai coderabbitai bot added the design Improvements & changes to design & UX label Jul 29, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cubic analysis

No issues found across 1 file. Review in cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

design Improvements & changes to design & UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant