fix: update locale keys for Chinese language support

[zhyd1997]

Close #1875

READ CAREFULLY THEN REMOVE

Remove bullet points that are not relevant.

PLEASE REFRAIN FROM USING AI TO WRITE YOUR CODE AND PR DESCRIPTION. IF YOU DO USE AI TO WRITE YOUR CODE PLEASE PROVIDE A DESCRIPTION AND REVIEW IT CAREFULLY. MAKE SURE YOU UNDERSTAND THE CODE YOU ARE SUBMITTING USING AI.

• Pull requests that do not follow these guidelines will be closed without review or comment.
• If you use AI to write your PR description your pr will be close without review or comment.
• If you are unsure about anything, feel free to ask for clarification.

Description

Please provide a clear description of your changes.

---

Type of Change

Please delete options that are not relevant.

• 🐛 Bug fix (non-breaking change which fixes an issue)
• ✨ New feature (non-breaking change which adds functionality)
• 💥 Breaking change (fix or feature with breaking changes)
• 📝 Documentation update
• 🎨 UI/UX improvement
• 🔒 Security enhancement
• ⚡ Performance improvement

Areas Affected

Please check all that apply:

• Email Integration (Gmail, IMAP, etc.)
• User Interface/Experience
• Authentication/Authorization
• Data Storage/Management
• API Endpoints
• Documentation
• Testing Infrastructure
• Development Workflow
• Deployment/Infrastructure

Testing Done

Describe the tests you've done:

• Unit tests added/updated
• Integration tests added/updated
• Manual testing performed
• Cross-browser testing (if UI changes)
• Mobile responsiveness verified (if UI changes)

Security Considerations

For changes involving data or authentication:

• No sensitive data is exposed
• Authentication checks are in place
• Input validation is implemented
• Rate limiting is considered (if applicable)

Checklist

• I have read the CONTRIBUTING document
• My code follows the project's style guidelines
• I have performed a self-review of my code
• I have commented my code, particularly in complex areas
• I have updated the documentation
• My changes generate no new warnings
• I have added tests that prove my fix/feature works
• All tests pass locally
• Any dependent changes are merged and published

Additional Notes

Add any other context about the pull request here.

Screenshots/Recordings

---

By submitting this pull request, I confirm that my contribution is made under the terms of the project's license.

---

Summary by cubic

Updated the locale keys for Chinese language support from 'zh-CN' and 'zh-TW' to 'zh_CN' and 'zh_TW' to match the required format.

Summary by CodeRabbit

• Refactor
  • Updated the locale keys for Chinese (Simplified) and Chinese (Traditional) to use underscores instead of hyphens. No changes to language names or other locale mappings.

[jazzberry-ai]

Bug Report

No bugs found.

_{Comments? Email us.}

[greptile-apps]

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

[coderabbitai]

Walkthrough

Locale keys for Chinese (Simplified) and Chinese (Traditional) in apps/mail/locales.ts were updated from hyphenated (zh-CN, zh-TW) to underscored (zh_CN, zh_TW). The language names and all other locale mappings remain unchanged.

Changes

Cohort / File(s)	Change Summary
Locale Key Format Update apps/mail/locales.ts	Changed locale keys from 'zh-CN', 'zh-TW' to 'zh_CN', 'zh_TW'. No other modifications.

Sequence Diagram(s)

No significant control flow or feature logic changes detected; skipping sequence diagram.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Assessment against linked issues

Objective	Addressed	Explanation
Fix invalid language tag usage so that zh-CN locale works correctly for viewing emails (#1875)	✅
Ensure Chinese language options display correctly in language settings (#1875)	✅

Assessment against linked issues: Out-of-scope changes

No out-of-scope changes detected.

Possibly related PRs

• feat: cleanup on settings-general page #1572: Introduced the locales object in apps/mail/locales.ts and utilized it for displaying language names, directly related to the current locale key modification.

Suggested labels

content, high priority

Suggested reviewers

• ahmetskilinc

Poem

Rocketing through locales, a dash to underscore—
Chinese tags now land safely, errors no more.
No RangeError crashes, just smooth email delight,
With zh_CN and zh_TW, the future looks bright.
🚀✨

(Mission accomplished, language bugs out of sight!)

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 78987ea and 72adca2.

📒 Files selected for processing (1)

• apps/mail/locales.ts (1 hunks)

🧰 Additional context used

📓 Path-based instructions (3)

**/*.{js,jsx,ts,tsx}

📄 CodeRabbit Inference Engine (AGENT.md)

**/*.{js,jsx,ts,tsx}: Use 2-space indentation
Use single quotes
Limit lines to 100 characters in width
Semicolons are required

Files:

• apps/mail/locales.ts

**/*.{js,jsx,ts,tsx,css}

📄 CodeRabbit Inference Engine (AGENT.md)

Use Prettier with sort-imports and Tailwind plugins

Files:

• apps/mail/locales.ts

**/*.{ts,tsx}

📄 CodeRabbit Inference Engine (AGENT.md)

Enable TypeScript strict mode

Files:

• apps/mail/locales.ts

🧠 Learnings (4)

📓 Common learnings

Learnt from: retrogtx
PR: Mail-0/Zero#1468
File: apps/server/src/trpc/routes/mail.ts:331-331
Timestamp: 2025-06-28T03:56:09.376Z
Learning: In apps/server/src/trpc/routes/mail.ts, the user indicated they are not using ISO format for the scheduleAt parameter, despite the frontend code showing toISOString() usage in the ScheduleSendPicker component.

Learnt from: retrogtx
PR: Mail-0/Zero#1734
File: apps/server/src/lib/driver/google.ts:211-221
Timestamp: 2025-07-15T06:46:33.349Z
Learning: In apps/server/src/lib/driver/google.ts, the normalization of "draft" to "drafts" in the count() method is necessary because the navigation item in apps/mail/config/navigation.ts has id: 'drafts' (plural) while the Google API returns "draft" (singular). The nav-main.tsx component matches stats by comparing stat.label with item.id, so the backend must return "drafts" for the draft counter badge to appear in the sidebar.

Learnt from: retrogtx
PR: Mail-0/Zero#1328
File: apps/mail/lib/hotkeys/mail-list-hotkeys.tsx:202-209
Timestamp: 2025-06-18T17:26:50.918Z
Learning: In apps/mail/lib/hotkeys/mail-list-hotkeys.tsx, the switchCategoryByIndex function using hardcoded indices for category hotkeys does not break when users reorder categories, contrary to the theoretical index-shifting issue. The actual implementation has constraints or mechanisms that prevent hotkey targeting issues.

Learnt from: snehendu098
PR: Mail-0/Zero#1323
File: apps/mail/lib/themes/theme-utils.ts:318-318
Timestamp: 2025-06-24T06:22:58.753Z
Learning: In the Mail-0/Zero theme system (apps/mail/lib/themes/theme-utils.ts), when color themes are being applied, all color values come in HSL format, so there's no need for additional format validation when converting colors with hslToHex().

📚 Learning: in apps/server/src/trpc/routes/mail.ts, the user indicated they are not using iso format for the sch...

Learnt from: retrogtx
PR: Mail-0/Zero#1468
File: apps/server/src/trpc/routes/mail.ts:331-331
Timestamp: 2025-06-28T03:56:09.376Z
Learning: In apps/server/src/trpc/routes/mail.ts, the user indicated they are not using ISO format for the scheduleAt parameter, despite the frontend code showing toISOString() usage in the ScheduleSendPicker component.

Applied to files:

• apps/mail/locales.ts

📚 Learning: in apps/server/src/lib/driver/google.ts, the normalization of "draft" to "drafts" in the count() met...

Learnt from: retrogtx
PR: Mail-0/Zero#1734
File: apps/server/src/lib/driver/google.ts:211-221
Timestamp: 2025-07-15T06:46:33.349Z
Learning: In apps/server/src/lib/driver/google.ts, the normalization of "draft" to "drafts" in the count() method is necessary because the navigation item in apps/mail/config/navigation.ts has id: 'drafts' (plural) while the Google API returns "draft" (singular). The nav-main.tsx component matches stats by comparing stat.label with item.id, so the backend must return "drafts" for the draft counter badge to appear in the sidebar.

Applied to files:

• apps/mail/locales.ts

📚 Learning: in apps/mail/lib/hotkeys/mail-list-hotkeys.tsx, the switchcategorybyindex function using hardcoded i...

Learnt from: retrogtx
PR: Mail-0/Zero#1328
File: apps/mail/lib/hotkeys/mail-list-hotkeys.tsx:202-209
Timestamp: 2025-06-18T17:26:50.918Z
Learning: In apps/mail/lib/hotkeys/mail-list-hotkeys.tsx, the switchCategoryByIndex function using hardcoded indices for category hotkeys does not break when users reorder categories, contrary to the theoretical index-shifting issue. The actual implementation has constraints or mechanisms that prevent hotkey targeting issues.

Applied to files:

• apps/mail/locales.ts

🔇 Additional comments (1)

apps/mail/locales.ts (1)

21-22: Houston, we have a problem! These locale keys are moving in the wrong direction.

Look, I've launched rockets and built neural networks, and this is giving me the same feeling as when a Falcon 9 is heading toward the ocean instead of the landing pad. Your PR objectives clearly state that zh_CN (underscore) was causing runtime errors with Intl.PluralRules, but you've just changed the keys TO use underscores instead of fixing them to use hyphens.

The BCP 47 standard - which is what browsers actually understand - uses zh-CN and zh-TW with hyphens, not underscores. This is like using the wrong fuel in a Raptor engine.

Apply this diff to fix the locale keys to use the correct BCP 47 format:

-  'zh_CN': 'Chinese (Simplified)',
-  'zh_TW': 'Chinese (Traditional)',
+  'zh-CN': 'Chinese (Simplified)',
+  'zh-TW': 'Chinese (Traditional)',

Let me verify this with the web to make sure we're not sending this rocket in the wrong direction:

What is the correct BCP 47 language tag format for Chinese Simplified and Traditional locales for use with JavaScript Intl APIs?

Likely an incorrect or invalid review comment.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[cubic-dev-ai]

cubic analysis

No issues found across 1 file. Review in cubic