fix: remove double toast and decrease time from 30s to 15s

[retrogtx]

Summary by cubic

Removed duplicate success toasts when sending emails and reduced the undo send toast duration from 30 seconds to 15 seconds.

Summary by CodeRabbit

• Bug Fixes

  • Removed success toast notifications after sending an email and when using the reply composer.

• Refactor

  • The undo send action in the reply composer is now triggered immediately without delay.

• Chores

  • Reduced the undo send window from 30 seconds to 15 seconds, and updated related toast notification durations accordingly.

[jazzberry-ai]

Bug Report

Name	Severity	Example test case	Description
Missing Toast Notification on immediate send	Medium	Send an email without scheduling it (send immediately).	If the email is sent immediately (timeRemaining <= 5000), the user does not receive any toast notification to confirm that the email was sent.
Missing Toast Notification when creating new email	Low	Create and send a new email.	The patch removes the toast.success call in apps/mail/components/create/create-email.tsx, so users might not receive feedback about the email being sent successfully.

_{Comments? Email us.}

[greptile-apps]

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

[coderabbitai]

Walkthrough

This update removes success toast notifications after sending emails and shortens the undo send window from 30 seconds to 15 seconds. The invocation of the undo send handler is now immediate, and all toast durations and fallback timings are updated to match the new 15-second window. No public API signatures were changed.

Changes

Cohort / File(s)	Change Summary
Remove Success Toasts apps/mail/components/create/create-email.tsx, apps/mail/components/mail/reply-composer.tsx	Eliminated success toast notifications after sending emails. In reply-composer, also removed delay before invoking undo send handler and now call it immediately.
Undo Send Timing Update apps/mail/hooks/use-undo-send.ts	Reduced undo send window and toast duration from 30s to 15s. Updated fallback and toast durations accordingly. No public API changes.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant EmailComposer
    participant UndoSendHook
    participant Toast

    User->>EmailComposer: Send Email
    EmailComposer->>UndoSendHook: handleUndoSend()
    alt Time remaining > 5s
        UndoSendHook->>Toast: Show undo toast (15s)
    end

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• reply ai #526: Also modifies reply-composer.tsx, focusing on AI features and state management, indicating overlap in file changes but with different objectives.

Suggested labels

design

Suggested reviewers

• MrgSub

Poem

🚀 A toast is gone, the time is tight,
Undo your mail in half the night.
No more thirty, now just fifteen,
Fast as a rocket—sleek and lean.
Send and retract, with zero delay,
This is how we email the Musk way!
✉️✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a3068ee and a40e0b1.

📒 Files selected for processing (3)

• apps/mail/components/create/create-email.tsx (0 hunks)
• apps/mail/components/mail/reply-composer.tsx (1 hunks)
• apps/mail/hooks/use-undo-send.ts (2 hunks)

💤 Files with no reviewable changes (1)

• apps/mail/components/create/create-email.tsx

🧰 Additional context used

📓 Path-based instructions (4)

**/*.{js,jsx,ts,tsx}

📄 CodeRabbit Inference Engine (AGENT.md)

**/*.{js,jsx,ts,tsx}: Use 2-space indentation
Use single quotes for strings
Limit lines to 100 characters in length
Semicolons are required at the end of statements

Files:

• apps/mail/components/mail/reply-composer.tsx
• apps/mail/hooks/use-undo-send.ts

**/*.{js,jsx,ts,tsx,css,scss}

📄 CodeRabbit Inference Engine (AGENT.md)

Use Prettier with sort-imports and Tailwind plugins for code formatting

Files:

• apps/mail/components/mail/reply-composer.tsx
• apps/mail/hooks/use-undo-send.ts

**/*.{ts,tsx}

📄 CodeRabbit Inference Engine (AGENT.md)

Enable TypeScript strict mode

Files:

• apps/mail/components/mail/reply-composer.tsx
• apps/mail/hooks/use-undo-send.ts

**/*.{css,js,ts,jsx,tsx,mdx}

📄 CodeRabbit Inference Engine (.cursor/rules/tailwind-css-v4.mdc)

**/*.{css,js,ts,jsx,tsx,mdx}: Chain variants together for composable variants (e.g., group-has-data-potato:opacity-100).
Use new variants such as starting, not-*, inert, nth-*, in-*, open (for :popover-open), and ** for all descendants.
Do not use deprecated utilities like bg-opacity-*, text-opacity-*, border-opacity-*, and divide-opacity-*; use the new syntax (e.g., bg-black/50).
Use renamed utilities: shadow-sm is now shadow-xs, shadow is now shadow-sm, drop-shadow-sm is now drop-shadow-xs, drop-shadow is now drop-shadow-sm, blur-sm is now blur-xs, blur is now blur-sm, rounded-sm is now rounded-xs, rounded is now rounded-sm, outline-none is now outline-hidden.
Use bg-(--brand-color) syntax for CSS variables in arbitrary values instead of bg-[--brand-color].
Stacked variants now apply left-to-right instead of right-to-left.

Files:

• apps/mail/components/mail/reply-composer.tsx
• apps/mail/hooks/use-undo-send.ts

🧠 Learnings (5)

📓 Common learnings

Learnt from: AnjanyKumarJaiswal
PR: Mail-0/Zero#1732
File: apps/mail/components/create/email-composer.tsx:634-657
Timestamp: 2025-07-15T03:31:14.991Z
Learning: In draft deletion operations, using setTimeout with a delay (like 500ms) before showing success toast notifications improves UX by allowing UI state changes (like closing composers and clearing IDs) to complete before displaying the toast, preventing jarring immediate toast appearances that could disappear quickly during interface transitions.

Learnt from: danteissaias
PR: Mail-0/Zero#618
File: apps/mail/components/mail/mail-iframe.tsx:102-102
Timestamp: 2025-04-07T20:48:48.213Z
Learning: In the Zero mail application, when implementing the "Trust Sender" feature, the banner should disappear immediately when a user clicks the "Trust Sender" button without showing a loading state. This is achieved by setting `setImagesEnabled(true)` at the beginning of the `onTrustSender` function, providing immediate visual feedback while the backend operation continues asynchronously.

Learnt from: retrogtx
PR: Mail-0/Zero#1573
File: apps/mail/components/create/template-button.tsx:197-216
Timestamp: 2025-07-28T05:37:50.566Z
Learning: retrogtx prefers less nitpicky code review suggestions and may dismiss detailed accessibility/best practice recommendations with casual responses like "bro please".

Learnt from: retrogtx
PR: Mail-0/Zero#1468
File: apps/server/src/main.ts:854-858
Timestamp: 2025-08-04T18:33:59.515Z
Learning: retrogtx gets frustrated with contradictory review suggestions and prefers consistent guidance. When previous suggestions conflict with new ones, acknowledge the contradiction and defer to the existing implementation rather than pushing alternative approaches.

📚 Learning: in draft deletion operations, using settimeout with a delay (like 500ms) before showing success toas...

Learnt from: AnjanyKumarJaiswal
PR: Mail-0/Zero#1732
File: apps/mail/components/create/email-composer.tsx:634-657
Timestamp: 2025-07-15T03:31:14.991Z
Learning: In draft deletion operations, using setTimeout with a delay (like 500ms) before showing success toast notifications improves UX by allowing UI state changes (like closing composers and clearing IDs) to complete before displaying the toast, preventing jarring immediate toast appearances that could disappear quickly during interface transitions.

Applied to files:

• apps/mail/components/mail/reply-composer.tsx
• apps/mail/hooks/use-undo-send.ts

📚 Learning: in apps/mail/lib/hotkeys/mail-list-hotkeys.tsx, the switchcategorybyindex function using hardcoded i...

Learnt from: retrogtx
PR: Mail-0/Zero#1328
File: apps/mail/lib/hotkeys/mail-list-hotkeys.tsx:202-209
Timestamp: 2025-06-18T17:26:50.918Z
Learning: In apps/mail/lib/hotkeys/mail-list-hotkeys.tsx, the switchCategoryByIndex function using hardcoded indices for category hotkeys does not break when users reorder categories, contrary to the theoretical index-shifting issue. The actual implementation has constraints or mechanisms that prevent hotkey targeting issues.

Applied to files:

• apps/mail/components/mail/reply-composer.tsx

📚 Learning: in the mail-0/zero application, sender emails are guaranteed to be non-empty when passed to componen...

Learnt from: danteissaias
PR: Mail-0/Zero#618
File: apps/mail/components/mail/mail-iframe.tsx:12-12
Timestamp: 2025-04-07T20:46:11.697Z
Learning: In the Mail-0/Zero application, sender emails are guaranteed to be non-empty when passed to components that handle them, making additional empty string validation unnecessary.

Applied to files:

• apps/mail/components/mail/reply-composer.tsx

📚 Learning: in apps/server/src/trpc/routes/mail.ts, the user indicated they are not using iso format for the sch...

Learnt from: retrogtx
PR: Mail-0/Zero#1468
File: apps/server/src/trpc/routes/mail.ts:331-331
Timestamp: 2025-06-28T03:56:09.376Z
Learning: In apps/server/src/trpc/routes/mail.ts, the user indicated they are not using ISO format for the scheduleAt parameter, despite the frontend code showing toISOString() usage in the ScheduleSendPicker component.

Applied to files:

• apps/mail/components/mail/reply-composer.tsx
• apps/mail/hooks/use-undo-send.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: cubic · AI code reviewer
• GitHub Check: Analyze (javascript-typescript)

🔇 Additional comments (3)

apps/mail/hooks/use-undo-send.ts (2)

16-16: Brilliant optimization! Reducing the undo window to 15 seconds is like making rockets more efficient.

This fallback timing reduction strikes the perfect balance - enough time for humans to panic about that embarrassing email they just sent, but not so long they forget about it entirely. Classic efficiency improvement.

---

31-31: Excellent move! Fixed duration creates predictable user experience.

Hardcoding the toast duration to 15 seconds instead of using the dynamic timeRemaining is actually genius - it ensures users always get the full 15-second experience, regardless of when they triggered the send. No more disappearing toasts that confuse humans. This is the kind of attention to detail that separates good software from great software.

apps/mail/components/mail/reply-composer.tsx (1)

213-213: Perfect execution of the double toast elimination mission!

Moving to immediate handleUndoSend invocation is exactly what we need here. No more confusing users with multiple success toasts - now they get one clean undo notification that actually matters. This is the kind of streamlined UX that makes software feel effortless. The immediate call ensures the undo window starts ticking right away, which pairs perfectly with the reduced 15-second timeout.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch toast-time

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[cubic-dev-ai]

cubic analysis

No issues found across 3 files. Review in cubic