Skip to content

Comments

fix: show hand cursor on all buttons#1993

Merged
ahmetskilinc merged 1 commit intoMail-0:stagingfrom
tanayyo1:patch-1
Aug 22, 2025
Merged

fix: show hand cursor on all buttons#1993
ahmetskilinc merged 1 commit intoMail-0:stagingfrom
tanayyo1:patch-1

Conversation

@tanayyo1
Copy link
Contributor

@tanayyo1 tanayyo1 commented Aug 19, 2025

Added cursor-pointer to the base Button component so all buttons show a hand on hover. Improves click feedback everywhere.


Summary by cubic

Added cursor-pointer to the base Button component so all buttons show a hand cursor on hover, improving click feedback across the app.

Summary by CodeRabbit

  • Style
    • Buttons now display a pointer cursor by default, improving the visual cue for clickability across the mail interface.
    • Applies consistently to all button variants and sizes for a uniform experience.
    • Visual/interaction-only change; no adjustments to functionality or settings are required.

Added cursor pointer to Button so all buttons show hand on hover. Improves click feedback everywhere.
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 19, 2025

Walkthrough

Added the CSS class cursor-pointer to the base buttonVariants in apps/mail/components/ui/button.tsx. No changes to variants, sizes, or public API.

Changes

Cohort / File(s) Summary
UI Button Styling
apps/mail/components/ui/button.tsx
Add cursor-pointer to base buttonVariants classes; no API or signature changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

design

Suggested reviewers

  • MrgSub
  • nizzyabi

Poem

Clicks engage, the pointer flies—
A tiny tweak, but optimized.
Buttons signal, “Tap me, friend,”
UX rockets to ascend.
One class added, swift and clean—
Onward, Mars-grade UI sheen. 🚀

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@coderabbitai coderabbitai bot requested review from MrgSub and nizzyabi August 19, 2025 21:15
@coderabbitai coderabbitai bot added the design Improvements & changes to design & UX label Aug 19, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
apps/mail/components/ui/button.tsx (1)

49-53: Bug: className is being passed into buttonVariants instead of merged

buttonVariants only understands declared variants (variant, size). Passing className inside the options object is ignored (or type-errored in strict mode). Merge it with cn instead.

Apply this diff:

-        className={cn(buttonVariants({ variant, size, className }))}
+        className={cn(buttonVariants({ variant, size }), className)}
📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 576dfcc and 52509bf.

📒 Files selected for processing (1)
  • apps/mail/components/ui/button.tsx (1 hunks)
🧰 Additional context used
📓 Path-based instructions (4)
**/*.{css,js,ts,jsx,tsx,mdx}

📄 CodeRabbit Inference Engine (.cursor/rules/tailwind-css-v4.mdc)

**/*.{css,js,ts,jsx,tsx,mdx}: Chain variants together for composable variants (e.g., group-has-data-potato:opacity-100).
Use new variants such as starting, not-*, inert, nth-*, in-*, open (for :popover-open), and ** for all descendants.
Do not use deprecated utilities like bg-opacity-*, text-opacity-*, border-opacity-*, and divide-opacity-*; use the new syntax (e.g., bg-black/50).
Use renamed utilities: shadow-sm is now shadow-xs, shadow is now shadow-sm, drop-shadow-sm is now drop-shadow-xs, drop-shadow is now drop-shadow-sm, blur-sm is now blur-xs, blur is now blur-sm, rounded-sm is now rounded-xs, rounded is now rounded-sm, outline-none is now outline-hidden.
Use bg-(--brand-color) syntax for CSS variables in arbitrary values instead of bg-[--brand-color].
Stacked variants now apply left-to-right instead of right-to-left.

Files:

  • apps/mail/components/ui/button.tsx
**/*.{js,jsx,ts,tsx}

📄 CodeRabbit Inference Engine (AGENT.md)

**/*.{js,jsx,ts,tsx}: Use 2-space indentation
Use single quotes
Limit lines to 100 characters
Semicolons are required

Files:

  • apps/mail/components/ui/button.tsx
**/*.{js,jsx,ts,tsx,css}

📄 CodeRabbit Inference Engine (AGENT.md)

Use Prettier with sort-imports and Tailwind plugins

Files:

  • apps/mail/components/ui/button.tsx
**/*.{ts,tsx}

📄 CodeRabbit Inference Engine (AGENT.md)

Enable TypeScript strict mode

Files:

  • apps/mail/components/ui/button.tsx
🔇 Additional comments (1)
apps/mail/components/ui/button.tsx (1)

19-21: Dropdown item variant still forces cursor-default — undermines “all buttons” objective

This variant sets cursor-default, which will override the new base cursor-pointer given CVA merges base then variants. Net effect: dropdownItem buttons won’t show a hand cursor.

  • If the intent is truly “all buttons show pointer,” replace cursor-default with cursor-pointer here.
  • If dropdown items should remain non-pointer, adjust the PR description to clarify the exception.

Want me to update the variant and validate hover behavior across menus?

@ahmetskilinc ahmetskilinc merged commit 12153e8 into Mail-0:staging Aug 22, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

design Improvements & changes to design & UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants