changes the loading indicator in mail/threads

[ahmetskilinc]

changes the loading indicator in mail/threads

old:
says "Loading mail content"

CleanShot.2025-03-24.at.01.48.21.mp4

new:
now has skeleton instead of the ugly loading indicator

CleanShot.2025-03-24.at.01.44.38.mp4

Summary by CodeRabbit

• New Features

  • Enhanced the mail loading experience with a refreshed visual indicator that better represents content placeholders.
  • Improved the skeleton display by introducing clear visual dividers for a cleaner, more organized loading interface.

• Style

  • Refined layout spacing for a more compact and consistent presentation across views.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
0	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 24, 2025 1:51am

[coderabbitai]

Walkthrough

This pull request updates several mail components to improve the loading state display and code clarity. In the MailIframe component, the previous loader indication is replaced with a structured layout using multiple Skeleton components and reduced padding. In the MailDisplaySkeleton component, class names have been adjusted and Separator components added between sections. The ThreadDisplay component has received cosmetic formatting improvements for better code readability, with no functional changes to the loading logic or control flow.

Changes

File(s)	Change Summary
apps/mail/components/mail/mail-iframe.tsx apps/mail/components/mail/mail-skeleton.tsx	Mail Loading UI Enhancements: - Replaced the Loader2 component and text with structured groups of Skeleton components. - Reduced container padding (from p-8 to p-4) in MailIframe. - In MailDisplaySkeleton, removed specific border/background classes and added Separator elements.
apps/mail/components/mail/thread-display.tsx	Cosmetic Formatting Adjustments: - Improved indentation and alignment for better readability. - Reformatted a conditional rendering expression for the icon prop without altering functionality.

Possibly related PRs

• fixing the virtual mail-list #475: Modifies the MailIframe component to enhance the loading UI with Skeleton components, showing similar structural adjustments.
• Revert "fixing the virtual mail-list" #476: Reverts an earlier change to the MailIframe loading state, directly relating to the adjustments made in this PR.

Suggested reviewers

• nizzyabi
• MrgSub

Poem

I'm a rabbit with a code-filled heart,
Hopping through components with a joyful start,
Skeletons replace the old loader's call,
Separators neatly divide, standing tall,
With formatting tweaks that shine so bright,
My little paws cheer this code insight,
Happy hops for a PR done right!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6bb3e48 and d2f42bb.

📒 Files selected for processing (3)

• apps/mail/components/mail/mail-iframe.tsx (2 hunks)
• apps/mail/components/mail/mail-skeleton.tsx (4 hunks)
• apps/mail/components/mail/thread-display.tsx (3 hunks)

🧰 Additional context used

🧬 Code Definitions (2)

apps/mail/components/mail/mail-iframe.tsx (1)

apps/mail/components/ui/skeleton.tsx (1)

• Skeleton (7-7)

apps/mail/components/mail/thread-display.tsx (4)

apps/mail/lib/utils.ts (2)

• FOLDERS (8-15)
• cn (47-47)

apps/mail/lib/thread-actions.ts (2)

• ThreadDestination (4-4)
• moveThreadsTo (43-81)

apps/mail/components/mail/thread-subject.tsx (1)

• ThreadSubject (15-73)

apps/mail/components/mail/reply-composer.tsx (1)

• ReplyCompose (21-414)

🔇 Additional comments (7)

apps/mail/components/mail/mail-skeleton.tsx (3)

2-2: Good addition of Separator component for improved visual organization.

Adding the Separator component from Radix UI is a good choice for creating visual divisions between skeleton sections.

---

12-13: Nice simplification of styling approach.

The removal of border, background colors, and margins in favor of a cleaner styling approach improves the overall consistency of the skeleton UI. This change aligns well with the PR objective of enhancing the loading indicator experience.

Also applies to: 53-54, 94-95

---

50-50: Excellent use of Separator for visual hierarchy.

The addition of Separator components between sections creates a clearer visual hierarchy without relying on borders and background colors, resulting in a more modern and cleaner design.

Also applies to: 91-91

apps/mail/components/mail/mail-iframe.tsx (2)

4-4: Good import of Skeleton component for enhanced loading states.

Adding the Skeleton import prepares the file for implementing a more sophisticated loading UI that better represents the final content structure.

---

64-76: Great implementation of skeleton loading pattern.

Replacing the previous loading indicator with a structured skeleton UI is excellent. This approach provides users with a visual placeholder that mirrors the actual content layout, creating a more seamless loading experience that aligns perfectly with the PR's objective of improving the loading indicator.

The implementation with varying skeleton widths creates a natural-looking placeholder effect that simulates text content. The reduced padding (p-4 instead of previous p-8) also creates a more compact and modern appearance.

apps/mail/components/mail/thread-display.tsx (2)

307-307: Good simplification of conditional icon logic.

The refactored condition for determining whether to show the StarOff or Star icon is cleaner and more readable.

---

201-478: Clean code formatting improves readability.

The consistent indentation and spacing throughout this section makes the code more readable and maintainable without changing any functionality. This type of clean-up is valuable for long-term code health.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.