fix: join waitlist button contrast by mezotv · Pull Request #603 · Mail-0/Zero

mezotv · 2025-04-06T17:46:15Z

Description

The old contrast was terrible in light mode, so now I just made it black so it is always readable.

Type of Change

Please delete options that are not relevant.

🎨 UI/UX improvement

Areas Affected

Please check all that apply:

User Interface/Experience

Testing Done

Describe the tests you've done:

Unit tests added/updated
Integration tests added/updated
Manual testing performed
Cross-browser testing (if UI changes)
Mobile responsiveness verified (if UI changes)

Checklist

I have read the CONTRIBUTING document
My code follows the project's style guidelines
I have performed a self-review of my code
I have commented my code, particularly in complex areas
I have updated the documentation
My changes generate no new warnings
I have added tests that prove my fix/feature works
All tests pass locally
Any dependent changes are merged and published

Summary by CodeRabbit

Style
- Refined the appearance of a button to enhance text contrast and clarity for a better visual experience.

The old contrast was terrible in light mode, so now I just made it black so it is always readable.

vercel · 2025-04-06T17:46:19Z

@mezotv is attempting to deploy a commit to the Zero Team on Vercel.

A member of the Team first needs to authorize it.

coderabbitai · 2025-04-06T17:46:24Z

Walkthrough

The change updates the styling of a Button component within the Hero function in the mail application. An additional class, text-gray-900, has been appended to the existing class list, modifying the text color of the button. There are no changes to exported or public entities.

Changes

File(s)	Change Summary
apps/mail/components/home/hero.tsx	Appended `text-gray-900` to the Button component's class attribute to adjust the text color.

Suggested reviewers

needleXO

Poem

I’m just a rabbit, small and bright,
Hopping through code by day and night.
A little style tweak made the text shine clear,
Carrots and code, bringing cozy cheer.
Hop along, my friend, and give a cheer!

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai plan to trigger planning for file edits and PR creation.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

This reverts parts of commit cef74f3.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

apps/mail/components/home/hero.tsx (1)

160-163: Enhanced Button Contrast with Potential Dark Mode Impact

The added text-gray-900 class boosts contrast for the join waitlist button in light mode, directly addressing the PR objective. Please verify that this change doesn’t conflict with dark mode styling. If dark mode design requires a different text color (for example, a lighter tint), consider conditionally adding a dark mode override such as dark:text-white.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d64cb95 and cef74f3.

⛔ Files ignored due to path filters (1)

bun.lock is excluded by !**/*.lock

📒 Files selected for processing (1)

apps/mail/components/home/hero.tsx (1 hunks)

mezotv · 2025-04-06T17:50:18Z

Before:

After:

* fix: show primary emails * (review) add "All Mail" section to inbox switcher * ph provider * perf: switch from open ai to groq api * chore: remove openai package * chore: remove duplicated function * chore: remove duplicated function * feat: use system prompt from env * perf: use base js fetch instead of better-fetch * homepage open fix * context * cleanup * cleanup * feat: update categories logic * cleanup * cleanup * feat: use nuqs * action buttons * feat: added mark as read functionality for mails * added try and catch for better error handling * better error than codeRabbit lmao * hold to scroll down emails * fix spacing on reply composer ; * spacing * tooltip to thread display bar for ux * fix to reply composer * forward emails button * cleanup * cleanup * reply ring * overflow * cleanup * un animate x * New translations en.json (French) * New translations en.json (Spanish) * New translations en.json (Arabic) * New translations en.json (Catalan) * New translations en.json (Czech) * New translations en.json (German) * New translations en.json (Japanese) * New translations en.json (Korean) * New translations en.json (Polish) * New translations en.json (Portuguese) * New translations en.json (Russian) * New translations en.json (Turkish) * New translations en.json (Latvian) * New translations en.json (Hindi) * New translations en.json (Russian) * New translations en.json (Latvian) * cleanup * loading state and padding to mail list to not overflow when scrolling * onMouseDown * fix: remove html from AI prompt (#598) * fix: remove html from AI prompt * refact: use cheerio util to remove html from email * feat: add regex to ai-search * chore: remove debug logs * refactor: migrate from groq embeddings to openai for and improve email formatting * fix: join waitlist button contrast (#603) * fix: join waitlist button contrast The old contrast was terrible in light mode, so now I just made it black so it is always readable. * Revert "regenerating bun file" This reverts parts of commit cef74f3. * Add tooltips and i18n for editor MenuBar (#604) * feat: add tooltips and i18n to editor MenuBar * fix: incorrect translation key --------- Co-authored-by: Sergio Vazquez <sergiovazag@gmail.com> Co-authored-by: plyght <plyght@peril.lol> Co-authored-by: Sergio <60497216+sergio-jva@users.noreply.github.com> Co-authored-by: Nizzy <nizabizaher@gmail.com> Co-authored-by: Vicentesan <vikom.sanchez@gmail.com> Co-authored-by: user12224 <122770437+user12224@users.noreply.github.com> Co-authored-by: Rajmeet <rajmeetchandok@gmail.com> Co-authored-by: [bot] <zero@ibra.rip> Co-authored-by: needle <122770437+needleXO@users.noreply.github.com> Co-authored-by: Dominik Koch <dominik@koch-bautechnik.de> Co-authored-by: YK <70700647+yaraslau-klimuk@users.noreply.github.com>

fix: join waitlist button contrast

cef74f3

The old contrast was terrible in light mode, so now I just made it black so it is always readable.

Revert "regenerating bun file"

d6a6378

This reverts parts of commit cef74f3.

coderabbitai bot reviewed Apr 6, 2025

View reviewed changes

nizzyabi merged commit 011b0d1 into Mail-0:staging Apr 6, 2025
2 of 3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

fix: join waitlist button contrast#603

fix: join waitlist button contrast#603
nizzyabi merged 2 commits intoMail-0:stagingfrom
mezotv:waitlist-contrast

mezotv commented Apr 6, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

vercel bot commented Apr 6, 2025

Uh oh!

coderabbitai bot commented Apr 6, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

mezotv commented Apr 6, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Comments

Conversation

mezotv commented Apr 6, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of Change

Areas Affected

Testing Done

Checklist

Summary by CodeRabbit

Uh oh!

vercel bot commented Apr 6, 2025

Uh oh!

coderabbitai bot commented Apr 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

mezotv commented Apr 6, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mezotv commented Apr 6, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 6, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)