Skip to content

Revert "fix: invite dialog colors #732"#735

Merged
ahmetskilinc merged 1 commit intomainfrom
revert-733-fix/invite-dialog-colors
Apr 21, 2025
Merged

Revert "fix: invite dialog colors #732"#735
ahmetskilinc merged 1 commit intomainfrom
revert-733-fix/invite-dialog-colors

Conversation

@ahmetskilinc
Copy link
Contributor

@ahmetskilinc ahmetskilinc commented Apr 21, 2025

Reverts #733

Summary by CodeRabbit

  • Style
    • Unified icon display for light and dark modes by using a single image with dynamic color inversion, replacing separate images for each theme.
    • Simplified placeholder styling for the email input field with consistent opacity across all modes.

@vercel
Copy link

vercel bot commented Apr 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
0 🔄 Building (Inspect) Visit Preview 💬 Add feedback Apr 21, 2025 0:44am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 21, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This update refactors several components to consolidate the handling of light and dark mode icons. Previously, each component used two separate <Image> elements to display different icons depending on the theme. The changes replace these with a single <Image> per icon, utilizing CSS classes (invert and dark:invert-0) to dynamically invert colors based on the current theme. This affects the login client, dialog titles, hero section, and navigation bar. Additionally, the email input placeholder opacity in the dialog is now set to a uniform low value across all themes.

Changes

Files/Paths Change Summary
apps/mail/app/(auth)/login/login-client.tsx Replaced dual light/dark mode images for provider icon and logo with a single image using CSS inversion.
apps/mail/components/golden.tsx Simplified dialog icon rendering to a single image; unified placeholder opacity for email input field.
apps/mail/components/home/hero.tsx Consolidated light/dark mode hero icon images into one using CSS inversion classes.
apps/mail/components/home/navbar.tsx Merged separate light/dark mode navbar icons into a single image with CSS-based color inversion.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Component
    participant CSS

    User->>Component: Render page/component
    Component->>CSS: Apply "invert" and "dark:invert-0" classes to <Image>
    CSS-->>Component: Adjust icon color based on theme
    Component-->>User: Display correct icon for light/dark mode
Loading

Possibly related PRs

  • fix: invite dialog colors #732 #733: Reverses this PR's approach in golden.tsx by splitting a single image into two for light and dark modes, directly opposing the consolidation strategy used here.

Poem

A hop and a skip, with a CSS trick,
One image now serves both dark and light quick!
No more toggling icons, no need to hide—
Just invert and display, let the theme decide.
With code made more simple, the bunny feels proud,
For less is now more—let’s shout it aloud!
🐇✨

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)
  • We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2c0e7f0 and bea3c9b.

📒 Files selected for processing (4)
  • apps/mail/app/(auth)/login/login-client.tsx (2 hunks)
  • apps/mail/components/golden.tsx (2 hunks)
  • apps/mail/components/home/hero.tsx (1 hunks)
  • apps/mail/components/home/navbar.tsx (2 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ahmetskilinc ahmetskilinc merged commit 37c7ee1 into main Apr 21, 2025
2 of 4 checks passed
@ahmetskilinc ahmetskilinc deleted the revert-733-fix/invite-dialog-colors branch April 21, 2025 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant