Allow sending from email aliases added through gmail#743
Allow sending from email aliases added through gmail#743ahmetskilinc merged 1 commit intoMail-0:stagingfrom atharvadeosthale:atharva/send-using-alias
Conversation
|
@atharvadeosthale is attempting to deploy a commit to the Zero Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThis update introduces comprehensive support for selecting the sender email address ("From" field) when composing or replying to emails. It adds backend and frontend logic for retrieving email aliases, updates the email sending flow to allow specifying a custom sender address, and enhances the user interface with dropdown menus for alias selection. The changes include new server-side modules, driver interface extensions, React hooks, and UI components, as well as corresponding updates to localization and type definitions. Error handling and fallback mechanisms are implemented to ensure robust alias retrieval and usage. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant ComposeUI as Compose/Reply UI
participant useEmailAliases
participant Backend as /api/driver/email-aliases
participant getEmailAliases
participant Driver
participant Provider
User->>ComposeUI: Open compose or reply
ComposeUI->>useEmailAliases: Fetch aliases
useEmailAliases->>Backend: GET /api/driver/email-aliases
Backend->>getEmailAliases: Call getEmailAliases()
getEmailAliases->>Driver: driver.getEmailAliases()
Driver->>Provider: Fetch aliases from provider (e.g., Gmail)
Provider-->>Driver: Return alias data
Driver-->>getEmailAliases: Return aliases
getEmailAliases-->>Backend: Return aliases
Backend-->>useEmailAliases: Return aliases
useEmailAliases-->>ComposeUI: Provide aliases
User->>ComposeUI: Select "From" alias and send email
ComposeUI->>sendEmail: Call sendEmail({ ..., fromEmail })
sendEmail->>Driver: driver.create({ ..., fromEmail })
Driver->>Provider: Send email with specified fromEmail
Provider-->>Driver: Confirmation
Driver-->>sendEmail: Return result
Suggested reviewers
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
apps/mail/components/create/create-email.tsx (1)
360-362: 🛠️ Refactor suggestionReset the selectedFromEmail state when clearing the form.
After successfully sending an email, the component resets all form fields except the selectedFromEmail state. This could cause unexpected behavior if the user composes another email.
setBccEmails([]); setShowCc(false); setShowBcc(false); + setSelectedFromEmail(null); setSubjectInput(''); setAttachments([]); setMessageContent('');
🧹 Nitpick comments (3)
apps/mail/hooks/use-email-aliases.ts (2)
8-20: Well-implemented hook for email alias fetchingThe
useEmailAliaseshook is cleanly implemented usinguseSWRImmutable, which is appropriate for email aliases that don't change frequently. The implementation follows React best practices for data fetching hooks.Consider enhancing error handling to provide more graceful fallbacks when alias fetching fails, ensuring users can still send emails even if alias retrieval encounters issues.
export function useEmailAliases() { const { data, error, isLoading, mutate } = useSWRImmutable<EmailAlias[]>( '/api/driver/email-aliases', fetcher, ); return { aliases: data || [], isLoading, error, + isError: !!error, mutate, }; }
6-6: Consider adding error handling to the fetcherThe current fetcher doesn't handle HTTP error responses. Consider adding error handling to provide better diagnostic information when API calls fail.
-const fetcher = (url: string) => fetch(url).then((res) => res.json()); +const fetcher = async (url: string) => { + const res = await fetch(url); + if (!res.ok) { + throw new Error(`Failed to fetch email aliases: ${res.status} ${res.statusText}`); + } + return res.json(); +};apps/mail/components/create/create-email.tsx (1)
596-633: Add error handling for email alias fetch failures.The component doesn't handle potential errors when fetching email aliases. If the fetch fails, users won't know why no aliases appear.
<DropdownMenuContent className="w-[var(--radix-dropdown-trigger-width)]" align="start" > {isLoadingAliases ? ( <div className="px-2 py-1 text-center text-sm">Loading...</div> + ) : error ? ( + <div className="px-2 py-1 text-center text-sm text-destructive"> + Failed to load aliases + </div> ) : aliases && aliases.length > 0 ? ( aliases.map((alias) => (
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (9)
apps/mail/actions/email-aliases.ts(1 hunks)apps/mail/actions/send.ts(3 hunks)apps/mail/app/api/driver/google.ts(5 hunks)apps/mail/app/api/driver/types.ts(1 hunks)apps/mail/components/create/create-email.tsx(8 hunks)apps/mail/components/mail/reply-composer.tsx(11 hunks)apps/mail/hooks/use-email-aliases.ts(1 hunks)apps/mail/locales/en.json(2 hunks)apps/mail/types/index.ts(1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (2)
apps/mail/hooks/use-email-aliases.ts (1)
apps/mail/actions/email-aliases.ts (1)
EmailAlias(7-11)
apps/mail/components/create/create-email.tsx (3)
apps/mail/hooks/use-email-aliases.ts (1)
useEmailAliases(8-20)apps/mail/components/ui/dropdown-menu.tsx (4)
DropdownMenu(171-171)DropdownMenuTrigger(172-172)DropdownMenuContent(173-173)DropdownMenuItem(174-174)apps/mail/components/ui/button.tsx (1)
Button(55-55)
🔇 Additional comments (24)
apps/mail/app/api/driver/types.ts (1)
39-39: Clean interface extension for email alias supportThe addition of the
getEmailAliasesmethod to theMailManagerinterface is well-designed with an appropriate return type that captures all essential alias information (email address, optional display name, and primary status flag). This interface extension properly supports the PR objective of enabling Gmail alias selection.apps/mail/types/index.ts (1)
119-119: Well-designed type extension for sender alias supportThe addition of the optional
fromEmailproperty to theIOutgoingMessageinterface is clean and maintains backward compatibility. This change properly enables specifying a custom sender email address when composing messages, which is essential for the Gmail alias feature.apps/mail/actions/send.ts (1)
17-17: Clean implementation of fromEmail parameterThe
fromEmailparameter is correctly added to thesendEmailfunction signature and properly passed to the driver. The implementation maintains backward compatibility by making the parameter optional, ensuring a smooth integration with the email alias selection feature.Also applies to: 27-27, 56-56
apps/mail/locales/en.json (2)
90-90: LGTM! Added localization key for the new "From" field.The new localization key for the "From" field has been appropriately placed in the searchBar section, making it available throughout the application.
140-140: LGTM! Fixed formatting for "bcc" key.Small formatting correction for consistency with other keys in the localization file.
apps/mail/app/api/driver/google.ts (4)
232-243: LGTM! The outgoing message parser now supports custom sender email.The implementation correctly handles the optional
fromEmailparameter with appropriate fallback to the default email from the connection configuration. The debug logging helps with troubleshooting.
271-272: LGTM! Updated recipient debugging to use the dynamic sender email.The debugging output now correctly references the dynamic
senderEmailvariable instead of the hardcodedfromEmail.
314-315: LGTM! Updated CC and BCC filtering to use the dynamic sender email.The filtering logic now correctly excludes the sender's email from CC and BCC recipients using the dynamic
senderEmailvariable.Also applies to: 335-336
488-525: LGTM! Well-implemented email aliases retrieval.The implementation follows best practices:
- First retrieves the primary email from the profile
- Fetches all "sendAs" aliases configured in Gmail
- Combines them into a single array with appropriate metadata
- Includes comprehensive error handling
The method properly handles Gmail's API response structure and maintains type safety throughout.
apps/mail/actions/email-aliases.ts (2)
1-12: LGTM! Clean type definition and server-side action setup.The file starts with the server action directive and imports the necessary dependencies. The
EmailAliastype is well-defined with all the required fields.
13-36: LGTM! Well-implemented email aliases retrieval with proper error handling.The server action follows best practices:
- Gets the active connection and validates tokens
- Creates the appropriate driver for the connection
- Delegates the alias retrieval to the driver
- Provides a graceful fallback in case of errors
The function will never throw errors to the client, ensuring robust behavior even when the API call fails.
apps/mail/components/mail/reply-composer.tsx (6)
17-18: LGTM! Added necessary imports for dropdown functionality.The component properly imports the required UI components and hooks for the dropdown menu and email alias functionality.
Also applies to: 27-38
62-72: LGTM! Extracted DragOverlay for better code organization.Moving the
DragOverlaycomponent to the top of the file improves code organization and readability.
184-185: LGTM! Added state for From email selection and API integration.The component properly manages the selected "From" email with React state and integrates with the
useEmailAliaseshook to fetch available aliases.
348-348: LGTM! Updated sendEmail to include the selected From email.The
sendEmailcall now includes thefromEmailparameter with appropriate fallback logic if no alias is selected.
777-812: LGTM! Well-implemented From email dropdown in the recipient editing view.The dropdown implementation:
- Shows a loading state while fetching aliases
- Properly displays the list of aliases with name and email
- Indicates the primary email address
- Falls back to the user's default email if no aliases are available
- Uses the appropriate UI components for a clean, consistent look
The dropdown is well-positioned in the UI next to the other recipient fields.
874-909: LGTM! Added From email dropdown to compact view.The dropdown is consistently implemented in the compact view, maintaining the same functionality and appearance as in the expanded view.
apps/mail/components/create/create-email.tsx (7)
8-8: LGTM! Import addition for dropdown UI.The ChevronDown icon import is correctly added for use in the From email dropdown menu.
11-11: LGTM! Hook import for fetching email aliases.The useEmailAliases hook import is correctly added to fetch Gmail aliases from the API.
91-91: LGTM! State for tracking selected email.The selectedFromEmail state variable is appropriately initialized as null and will store the user's chosen sender address.
120-120: LGTM! Hook initialization for email aliases.The hook is correctly implemented to fetch aliases and track loading state.
321-323: LGTM! Proper fallback logic for sender email.The code correctly implements a fallback chain:
- Uses the user-selected email if available
- Falls back to the first alias if available
- Defaults to the user's primary email as last resort
335-335: LGTM! Email sending integration.The fromEmail parameter is correctly passed to the sendEmail action.
596-633: LGTM! Well-implemented From email selector UI.The From email selector is implemented with:
- Clear labeling with translation support
- Loading state handling
- Proper display of email aliases with names and primary status indicators
- Disabled state during loading or when sending
- Appropriate dropdown positioning
The implementation follows the same pattern as other email fields in the form.
ahmetskilinc
left a comment
ahmetskilinc
left a comment
There was a problem hiding this comment.
I didn't even know you could add aliases in gmail. Good work. Lgtm
* draft fixes: - added cc and bcc when saving drafts - save drafts less aggresively * some fixes for saving attachments to draft * fix for empty draft loading * fix draft list recipient name/address * also show 'No Recipient' if empty * remove comments * switch to mimetext for draft saving to keep formatting consistent * add message title to draft list * feat: single api for oauth connections * fix: add extra error handling * chore: simplify and fix the dev env * Ai generate security (#706) * Create prompts with XML formatting * Include XML formatted prompts in generate func * remove unused regex and add helper functions/warnings * error handling * Update apps/mail/lib/prompts.ts Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * lint issues * Update prompts.ts * #706 (comment) Coderabbit fix 1 * erabbitai bot 3 days ago⚠️ Potential issue errorOccurred state is stale inside finally React state setters (setErrorOccurred) are asynchronous; the errorOccurred value captured at render time will not yet reflect changes made earlier in the same event loop. Consequently, the logic deciding whether to collapse/expand may run with an outdated flag. - } finally { - setIsLoading(false); - if (!errorOccurred || isAskingQuestion) { - setIsExpanded(true); - } else { - setIsExpanded(false); // Collapse on errors - } - } + } finally { + setIsLoading(false); + // Use a local flag to track errors deterministically + const hadError = isAskingQuestion ? false : !!errorFlagRef.current; + setIsExpanded(!hadError); + } You can create const errorFlagRef = useRef(false); and update errorFlagRef.current = true every time an error is detected, ensuring reliable behaviour irrespective of React batching. Committable suggestion skipped: line range outside the PR's diff. * #706 (comment) * #706 (comment) * #706 (comment) --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Add a new Vietnamese translation file to support Vietnamese language users (#726) * feat(i18n): add Vietnamese language support Add Vietnamese ('vi') to the list of supported languages in the i18n configuration and JSON file to expand language options. * Add a new Vietnamese translation file to support Vietnamese language users. * Clear Vietnamese translation strings * Update es.json (#710) Co-authored-by: needle <122770437+needleXO@users.noreply.github.com> * Update app manifest and add new icons for PWA (#739) * feat: allow sending from email aliases added through gmail (#743) * Refactor IP handling in early-access routes * Add unauthorized error handling in sign out function --------- Co-authored-by: Ahmet Kilinc <akx9@icloud.com> Co-authored-by: BlankParticle <blankparticle@gmail.com> Co-authored-by: grim <75869731+ripgrim@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Chánh Đại <dai@chanhdai.com> Co-authored-by: Dani B. <danibaldomirm@gmail.com> Co-authored-by: needle <122770437+needleXO@users.noreply.github.com> Co-authored-by: Humber Nieto <56887259+humbernieto@users.noreply.github.com> Co-authored-by: Atharva Deosthale <atharva.deosthale17@gmail.com>
|
@atharvadeosthale @ahmetskilinc - do we want to hide the From field if the user doesn't have any aliases set up etc? 
|
|
@AxelJetpack nice idea. I gave it a thought when coding it out. My only problem is that the Gmail API is really slow. When the compose page is opened, it took me 2-3 seconds to fetch email aliases. If we implement the from field only appearing if aliases is found, it will cause an ugly layout shift every time a user goes to the compose page and has an alias. My recommendations (and would love some feedback, happy to work on them)
Do you have any recommendations? Would love to explore ideas to make this better. Thanks. |
* draft fixes: - added cc and bcc when saving drafts - save drafts less aggresively * some fixes for saving attachments to draft * fix for empty draft loading * fix draft list recipient name/address * also show 'No Recipient' if empty * remove comments * switch to mimetext for draft saving to keep formatting consistent * add message title to draft list * feat: single api for oauth connections * fix: add extra error handling * chore: simplify and fix the dev env * Ai generate security (#706) * Create prompts with XML formatting * Include XML formatted prompts in generate func * remove unused regex and add helper functions/warnings * error handling * Update apps/mail/lib/prompts.ts Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * lint issues * Update prompts.ts * #706 (comment) Coderabbit fix 1 * erabbitai bot 3 days ago⚠️ Potential issue errorOccurred state is stale inside finally React state setters (setErrorOccurred) are asynchronous; the errorOccurred value captured at render time will not yet reflect changes made earlier in the same event loop. Consequently, the logic deciding whether to collapse/expand may run with an outdated flag. - } finally { - setIsLoading(false); - if (!errorOccurred || isAskingQuestion) { - setIsExpanded(true); - } else { - setIsExpanded(false); // Collapse on errors - } - } + } finally { + setIsLoading(false); + // Use a local flag to track errors deterministically + const hadError = isAskingQuestion ? false : !!errorFlagRef.current; + setIsExpanded(!hadError); + } You can create const errorFlagRef = useRef(false); and update errorFlagRef.current = true every time an error is detected, ensuring reliable behaviour irrespective of React batching. Committable suggestion skipped: line range outside the PR's diff. * #706 (comment) * #706 (comment) * #706 (comment) --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Add a new Vietnamese translation file to support Vietnamese language users (#726) * feat(i18n): add Vietnamese language support Add Vietnamese ('vi') to the list of supported languages in the i18n configuration and JSON file to expand language options. * Add a new Vietnamese translation file to support Vietnamese language users. * Clear Vietnamese translation strings * Update es.json (#710) Co-authored-by: needle <122770437+needleXO@users.noreply.github.com> * Update app manifest and add new icons for PWA (#739) * feat: allow sending from email aliases added through gmail (#743) * Refactor IP handling in early-access routes * Add unauthorized error handling in sign out function * Redirect from Home Page on Session (#701) * Updated lockfile * Updated home page session validation --------- Co-authored-by: Adam <x_1337@outlook.com> * Refactor settings handling and golden ticket logic * Feat: og:image Generation on /compose route (#730) * Create route og image * resolve coderabbit nitpicks --------- Co-authored-by: Adam <x_1337@outlook.com> * Update session check to include user id before redirecting * Fix unauthorized error handling in multiple actions * Enable shortcuts settings in navigation * Refactor error handling to return unauthorized gracefully * Update Hero component with new imports and link adjustments * Update redirect URL to use hostname from req object * Fix redirect URL formatting and add log for missing user ID * Fix error handling in API routes for unauthorized requests * Refactor throwUnauthorizedGracefully function for readability * Fix error handling in driver routes * Handle unauthorized gracefully when getting connections * Refactor mail actions for better error handling * Refactor deleteActiveConnection function for readability * fixed (#752) * Refactor error handling in mail actions to return null or specific error messages instead of throwing unauthorized errors. This improves readability and maintains functionality across various actions. * Update Google auth provider configuration * Delete connection and update hero text * Refactor error handling to use StandardizedError class * Refactor error handling for Google API driver --------- Co-authored-by: Ahmet Kilinc <akx9@icloud.com> Co-authored-by: BlankParticle <blankparticle@gmail.com> Co-authored-by: grim <75869731+ripgrim@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Chánh Đại <dai@chanhdai.com> Co-authored-by: Dani B. <danibaldomirm@gmail.com> Co-authored-by: needle <122770437+needleXO@users.noreply.github.com> Co-authored-by: Humber Nieto <56887259+humbernieto@users.noreply.github.com> Co-authored-by: Atharva Deosthale <atharva.deosthale17@gmail.com> Co-authored-by: Nikita Drokin <86173808+nikitadrokin@users.noreply.github.com>
* draft fixes: - added cc and bcc when saving drafts - save drafts less aggresively * some fixes for saving attachments to draft * fix for empty draft loading * fix draft list recipient name/address * also show 'No Recipient' if empty * remove comments * switch to mimetext for draft saving to keep formatting consistent * add message title to draft list * feat: single api for oauth connections * fix: add extra error handling * chore: simplify and fix the dev env * Ai generate security (#706) * Create prompts with XML formatting * Include XML formatted prompts in generate func * remove unused regex and add helper functions/warnings * error handling * Update apps/mail/lib/prompts.ts Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * lint issues * Update prompts.ts * #706 (comment) Coderabbit fix 1 * erabbitai bot 3 days ago⚠️ Potential issue errorOccurred state is stale inside finally React state setters (setErrorOccurred) are asynchronous; the errorOccurred value captured at render time will not yet reflect changes made earlier in the same event loop. Consequently, the logic deciding whether to collapse/expand may run with an outdated flag. - } finally { - setIsLoading(false); - if (!errorOccurred || isAskingQuestion) { - setIsExpanded(true); - } else { - setIsExpanded(false); // Collapse on errors - } - } + } finally { + setIsLoading(false); + // Use a local flag to track errors deterministically + const hadError = isAskingQuestion ? false : !!errorFlagRef.current; + setIsExpanded(!hadError); + } You can create const errorFlagRef = useRef(false); and update errorFlagRef.current = true every time an error is detected, ensuring reliable behaviour irrespective of React batching. Committable suggestion skipped: line range outside the PR's diff. * #706 (comment) * #706 (comment) * #706 (comment) --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Add a new Vietnamese translation file to support Vietnamese language users (#726) * feat(i18n): add Vietnamese language support Add Vietnamese ('vi') to the list of supported languages in the i18n configuration and JSON file to expand language options. * Add a new Vietnamese translation file to support Vietnamese language users. * Clear Vietnamese translation strings * Update es.json (#710) Co-authored-by: needle <122770437+needleXO@users.noreply.github.com> * Update app manifest and add new icons for PWA (#739) * feat: allow sending from email aliases added through gmail (#743) * Refactor IP handling in early-access routes * Add unauthorized error handling in sign out function * Redirect from Home Page on Session (#701) * Updated lockfile * Updated home page session validation --------- Co-authored-by: Adam <x_1337@outlook.com> * Refactor settings handling and golden ticket logic * Feat: og:image Generation on /compose route (#730) * Create route og image * resolve coderabbit nitpicks --------- Co-authored-by: Adam <x_1337@outlook.com> * Update session check to include user id before redirecting * Fix unauthorized error handling in multiple actions * Enable shortcuts settings in navigation * Refactor error handling to return unauthorized gracefully * Update Hero component with new imports and link adjustments * Update redirect URL to use hostname from req object * Fix redirect URL formatting and add log for missing user ID * Fix error handling in API routes for unauthorized requests * Refactor throwUnauthorizedGracefully function for readability * Fix error handling in driver routes * Handle unauthorized gracefully when getting connections * Refactor mail actions for better error handling * Refactor deleteActiveConnection function for readability * fixed (#752) * Refactor error handling in mail actions to return null or specific error messages instead of throwing unauthorized errors. This improves readability and maintains functionality across various actions. * Update Google auth provider configuration * Delete connection and update hero text * Refactor error handling to use StandardizedError class * Refactor error handling for Google API driver * Add labels to sidebar, labels settings and useLabels hook (#746) * Adds labels from the provider: - labels page in settings - labels page translations - added labels for google provider * useLabels and labels in sidebar * fix rate limit parts of labels route * Added labels to mail-list * - add rate limiting - move useThreadsLabel --------- Co-authored-by: Adam <x_1337@outlook.com> * bin count of unread messages * dixes drafts not saving persistently * dont show from field is no aliases * limited height of attachment dialog * added delete page * correct way to delete accounts * - adds new revokeRefreshToken method to Google driver - updates lib/auth.ts to use the new method - updates actions/user.ts - updates app/(routes)/settings/danger-zone/page.tsx * Add posthog-js dependency and implement label filtering in NavMain component - Added posthog-js version 1.236.6 to package.json and bun.lock. - Introduced search functionality by implementing handleFilterByLabel in NavMain component. - Updated NavItem to trigger label filtering on click. * Enhance NavItem component to support onClick event handling - Updated NavItem to include an onClick prop for the Link component, allowing for custom click behavior. - Maintained existing functionality with prefetch and target attributes. --------- Co-authored-by: Ahmet Kilinc <akx9@icloud.com> Co-authored-by: BlankParticle <blankparticle@gmail.com> Co-authored-by: grim <75869731+ripgrim@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Chánh Đại <dai@chanhdai.com> Co-authored-by: Dani B. <danibaldomirm@gmail.com> Co-authored-by: needle <122770437+needleXO@users.noreply.github.com> Co-authored-by: Humber Nieto <56887259+humbernieto@users.noreply.github.com> Co-authored-by: Atharva Deosthale <atharva.deosthale17@gmail.com> Co-authored-by: Nikita Drokin <86173808+nikitadrokin@users.noreply.github.com> Co-authored-by: Adarsh Tiwari <adarshtiwari797023@gmail.com>
* draft fixes: - added cc and bcc when saving drafts - save drafts less aggresively * some fixes for saving attachments to draft * fix for empty draft loading * fix draft list recipient name/address * also show 'No Recipient' if empty * remove comments * switch to mimetext for draft saving to keep formatting consistent * add message title to draft list * feat: single api for oauth connections * fix: add extra error handling * chore: simplify and fix the dev env * Ai generate security (#706) * Create prompts with XML formatting * Include XML formatted prompts in generate func * remove unused regex and add helper functions/warnings * error handling * Update apps/mail/lib/prompts.ts Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * lint issues * Update prompts.ts * #706 (comment) Coderabbit fix 1 * erabbitai bot 3 days ago⚠️ Potential issue errorOccurred state is stale inside finally React state setters (setErrorOccurred) are asynchronous; the errorOccurred value captured at render time will not yet reflect changes made earlier in the same event loop. Consequently, the logic deciding whether to collapse/expand may run with an outdated flag. - } finally { - setIsLoading(false); - if (!errorOccurred || isAskingQuestion) { - setIsExpanded(true); - } else { - setIsExpanded(false); // Collapse on errors - } - } + } finally { + setIsLoading(false); + // Use a local flag to track errors deterministically + const hadError = isAskingQuestion ? false : !!errorFlagRef.current; + setIsExpanded(!hadError); + } You can create const errorFlagRef = useRef(false); and update errorFlagRef.current = true every time an error is detected, ensuring reliable behaviour irrespective of React batching. Committable suggestion skipped: line range outside the PR's diff. * #706 (comment) * #706 (comment) * #706 (comment) --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Add a new Vietnamese translation file to support Vietnamese language users (#726) * feat(i18n): add Vietnamese language support Add Vietnamese ('vi') to the list of supported languages in the i18n configuration and JSON file to expand language options. * Add a new Vietnamese translation file to support Vietnamese language users. * Clear Vietnamese translation strings * Update es.json (#710) Co-authored-by: needle <122770437+needleXO@users.noreply.github.com> * Update app manifest and add new icons for PWA (#739) * feat: allow sending from email aliases added through gmail (#743) * Refactor IP handling in early-access routes * Add unauthorized error handling in sign out function * Redirect from Home Page on Session (#701) * Updated lockfile * Updated home page session validation --------- Co-authored-by: Adam <x_1337@outlook.com> * Refactor settings handling and golden ticket logic * Feat: og:image Generation on /compose route (#730) * Create route og image * resolve coderabbit nitpicks --------- Co-authored-by: Adam <x_1337@outlook.com> * Update session check to include user id before redirecting * Fix unauthorized error handling in multiple actions * Enable shortcuts settings in navigation * Refactor error handling to return unauthorized gracefully * Update Hero component with new imports and link adjustments * Update redirect URL to use hostname from req object * Fix redirect URL formatting and add log for missing user ID * Fix error handling in API routes for unauthorized requests * Refactor throwUnauthorizedGracefully function for readability * Fix error handling in driver routes * Handle unauthorized gracefully when getting connections * Refactor mail actions for better error handling * Refactor deleteActiveConnection function for readability * fixed (#752) * Refactor error handling in mail actions to return null or specific error messages instead of throwing unauthorized errors. This improves readability and maintains functionality across various actions. * Update Google auth provider configuration * Delete connection and update hero text * Refactor error handling to use StandardizedError class * Refactor error handling for Google API driver * Add labels to sidebar, labels settings and useLabels hook (#746) * Adds labels from the provider: - labels page in settings - labels page translations - added labels for google provider * useLabels and labels in sidebar * fix rate limit parts of labels route * Added labels to mail-list * - add rate limiting - move useThreadsLabel --------- Co-authored-by: Adam <x_1337@outlook.com> * bin count of unread messages * dixes drafts not saving persistently * dont show from field is no aliases * limited height of attachment dialog * added delete page * correct way to delete accounts * - adds new revokeRefreshToken method to Google driver - updates lib/auth.ts to use the new method - updates actions/user.ts - updates app/(routes)/settings/danger-zone/page.tsx * Add posthog-js dependency and implement label filtering in NavMain component - Added posthog-js version 1.236.6 to package.json and bun.lock. - Introduced search functionality by implementing handleFilterByLabel in NavMain component. - Updated NavItem to trigger label filtering on click. * Enhance NavItem component to support onClick event handling - Updated NavItem to include an onClick prop for the Link component, allowing for custom click behavior. - Maintained existing functionality with prefetch and target attributes. * fix: add missing dompurify dep (#765) * user can edit enail after selecting (#760) * User can able to delete from bin (#670) * delete mails permanently from bin * add English translations for delete mail actions * update the call handleDelete * fixed handle delete function * handleDelete call * enhance handledelete to reset bulk selection after deletion * removed the scope * delete mails permanently from bin * add English translations for delete mail actions * update the call handleDelete * handleDelete call * enhance handledelete to reset bulk selection after deletion * removed the scope --------- Co-authored-by: Ahmet Kilinc <akx9@icloud.com> Co-authored-by: Adam <x_1337@outlook.com> * send draft instead of new message (#767) * Add sendDraft method to Gmail driver and MailManager interface * fix sendDraft method * Add support for sending draft emails and clear draftId after sending --------- Co-authored-by: Adam <x_1337@outlook.com> * Add Chinese language support for mail app * Update email addresses in send function * Add import statement for deleteActiveConnection function --------- Co-authored-by: Ahmet Kilinc <akx9@icloud.com> Co-authored-by: BlankParticle <blankparticle@gmail.com> Co-authored-by: grim <75869731+ripgrim@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Chánh Đại <dai@chanhdai.com> Co-authored-by: Dani B. <danibaldomirm@gmail.com> Co-authored-by: needle <122770437+needleXO@users.noreply.github.com> Co-authored-by: Humber Nieto <56887259+humbernieto@users.noreply.github.com> Co-authored-by: Atharva Deosthale <atharva.deosthale17@gmail.com> Co-authored-by: Nikita Drokin <86173808+nikitadrokin@users.noreply.github.com> Co-authored-by: Adarsh Tiwari <adarshtiwari797023@gmail.com> Co-authored-by: Adarsh Tiwari <134617221+Adarsh9977@users.noreply.github.com>
3 participants
Description
Added a From field in email composer and reply composer. The aliases will be fetched through Gmail API and this will allow the user to send through an alias configured by them in Gmail settings.
Type of Change
Please delete options that are not relevant.
Areas Affected
Please check all that apply:
Testing Done
Describe the tests you've done:
Checklist
Additional Notes
This is primarily useful for people who avoid Google Workspace (like me) and use Cloudflare to route emails to personal Gmail account and configure the Gmail account to send from the domain.
Screenshots/Recordings
By submitting this pull request, I confirm that my contribution is made under the terms of the project's license.
Summary by CodeRabbit