Muted icon in Mailist and MailDisplay#8
Merged
nizzyabi merged 1 commit intoMail-0:mainfrom Feb 5, 2025
mnoebauer:main
Merged
Conversation
Contributor
mnoebauer
commented
Feb 5, 2025
mnoebauer
commented
- added muted icon in the MailList
- added functionality to the switch
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Author
|
Should it be to the extend that it affects the mailist too or fine like this for now |
Collaborator
|
niceee this is gonna be very nice once functionality is added |
MrgSub
requested changes
Feb 5, 2025
| const [isMuted, setIsMuted] = useState(mail ? mail.muted : false); | ||
|
|
||
| // Update the muted state when the mail prop changes. | ||
| useEffect(() => { |
Collaborator
There was a problem hiding this comment.
State not needed here, can use a variable & useMemo. If only for demo, it's fine
| aria-label="Mute thread" | ||
| checked={isMuted} | ||
| onCheckedChange={(checked: boolean) => | ||
| setIsMuted(checked) |
Collaborator
There was a problem hiding this comment.
Needs to go the backend, if only for demo it's fine
| defaultLayout: number[] | undefined; | ||
| defaultCollapsed?: boolean; | ||
| navCollapsedSize: number; | ||
| muted?: boolean; |
Collaborator
There was a problem hiding this comment.
muted: boolean | undefined to go with line 24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.